content/browser/download/save_package.h - Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package.h

Issue 1502563004: Save-Page-As-Complete-Html: Each frame links to a distinct local file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-url-deduping-for-frame-and-adding-save-item-id

Patch Set: Method signature changes: rewriteFrameSource + s/const WebFrame&/WebFrame*/ Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/save_page_browsertest.cc ('K') | « content/browser/download/save_item.cc ('k') | content/browser/download/save_package.cc » ('j') | content/browser/download/save_package.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/save_package.h

diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h

index f28cf3a089354e5d9dcc116f2a26229095ae3874..7ffaa0a1201fff76fa719eb0d1c50df28f8a012b 100644

--- a/content/browser/download/save_package.h

+++ b/content/browser/download/save_package.h

@@ -210,6 +210,7 @@ class CONTENT_EXPORT SavePackage

// Helper for finding or creating a SaveItem with the given parameters.

SaveItem* CreatePendingSaveItem(

int container_frame_tree_node_id,

+ int save_item_frame_tree_node_id,

const GURL& url,

const Referrer& referrer,

SaveFileCreateInfo::SaveFileSource save_source);

@@ -218,6 +219,7 @@ class CONTENT_EXPORT SavePackage

// creating a SaveItem with the given parameters.

SaveItem* CreatePendingSaveItemDeduplicatingByUrl(

int container_frame_tree_node_id,

+ int save_item_frame_tree_node_id,

const GURL& url,

const Referrer& referrer,

SaveFileCreateInfo::SaveFileSource save_source);