Save-Page-As-Complete-Html: Each frame links to a distinct local file.

chrome/browser/download/save_page_browsertest.cc

Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index fbbe0e3f66f6c9a6f5a57feaf3777baa42aabbfb..f73faeedba241f4240fd59667155e32f620f0967 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -1114,15 +1114,17 @@ IN_PROC_BROWSER_TEST_P(SavePageMultiFrameBrowserTest, RuntimeChanges) {
   std::vector<std::string> expected_substrings(std::begin(arr), std::end(arr));
 
   if (save_page_type == content::SAVE_PAGE_TYPE_AS_COMPLETE_HTML) {
-    // TODO(lukasza): crbug.com/106364: Expand complete-html test beyond just
-    // being a crash test.  In particular, the |complete_html_arr| below should
-    // be the same as the |arr| above (and at this point the special-casing of
+    // TODO(lukasza): crbug.com/106364: Expand complete-html test to cover all
+    // test frames.  In particular, the |complete_html_arr| below should be the

[Randy Smith (Not in Mondays), 2016/01/22 15:28:39]

I don't understand what is missing from this CL to enable this functionality? 
Are we dependent in the code somewhere on there being an associated URL for
frames even after this change?

[Łukasz Anforowicz, 2016/01/22 17:39:40]

This CL almost gets us there - the missing thing is handling of frames without
src attribute - these won't get rewritten to point to a locally saved file.  The
CL to handle src/srcdoc will come next, after the current CL lands.  A draft is
at crrev.com/1500103002.

+    // same as the |arr| above (and at this point the special-casing of
     // complete-html can be removed).
     // Draft CLs with fix proposals that should accomplish this:
     // - crrev.com/1502563004
     // - crrev.com/1500103002
     std::string complete_html_arr[] = {
         "frames-runtime-changes.htm: 4388232f-8d45-4d2e-9807-721b381be153",
+        "subframe1: 21595339-61fc-4854-b6df-0668328ea263",
+        "subframe2: adf55719-15e7-45be-9eda-d12fe782a1bd",
     };
     expected_substrings = std::vector<std::string>(
         std::begin(complete_html_arr), std::end(complete_html_arr));