Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=543161
Committed: https://crrev.com/900a22e14446afe123e66635fed7cbcb0532cec9
Cr-Commit-Position: refs/heads/master@{#363817}

[vakh (old account. dont use), 2015-12-04 01:28:31]

Description was changed from

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=477389
==========

to

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=477389
==========

[vakh (old account. dont use), 2015-12-04 01:28:32]

vakh@google.com changed reviewers:
+ nparker@chromium.org

[Nathan Parker, 2015-12-04 21:41:05]

lgtm

with a correction

https://codereview.chromium.org/1502483002/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config_linux.json (right):

https://codereview.chromium.org/1502483002/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config_linux.json:124: "group_name":
"UpdateTime15m"
You also need the param here to set it to 15 minutes.

I heard that currently only the first in this list is tested... in case that's
still try, put the "15m" one first since that affects the most new code.  Same
in other files.

[vakh (old account. dont use), 2015-12-08 19:25:32]

vakh@google.com changed reviewers:
+ isherman@chromium.org

[vakh (old account. dont use), 2015-12-08 19:25:33]

+isherman@

PTAL.

https://codereview.chromium.org/1502483002/diff/1/testing/variations/fieldtri...
File testing/variations/fieldtrial_testing_config_linux.json (right):

https://codereview.chromium.org/1502483002/diff/1/testing/variations/fieldtri...
testing/variations/fieldtrial_testing_config_linux.json:124: "group_name":
"UpdateTime15m"
On 2015/12/04 21:41:05, nparker wrote:
> You also need the param here to set it to 15 minutes.
> 
> I heard that currently only the first in this list is tested... in case that's
> still try, put the "15m" one first since that affects the most new code.  Same
> in other files.

Done.

[vakh (old account. dont use), 2015-12-08 19:27:23]

Description was changed from

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=477389
==========

to

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=543161
==========

[Ilya Sherman, 2015-12-08 20:01:12]

LGTM w/ the comment below addressed.  Note that I only mentioned it on one of
the files, but it applies to all of them.

https://codereview.chromium.org/1502483002/diff/20001/testing/variations/fiel...
File testing/variations/fieldtrial_testing_config_linux.json (right):

https://codereview.chromium.org/1502483002/diff/20001/testing/variations/fiel...
testing/variations/fieldtrial_testing_config_linux.json:128: }
You can omit the control and default groups.  These configs are meant to control
testing the new behavior.

[vakh (old account. dont use), 2015-12-08 20:49:17]

Thanks. PTAL.

https://codereview.chromium.org/1502483002/diff/20001/testing/variations/fiel...
File testing/variations/fieldtrial_testing_config_linux.json (right):

https://codereview.chromium.org/1502483002/diff/20001/testing/variations/fiel...
testing/variations/fieldtrial_testing_config_linux.json:128: }
On 2015/12/08 20:01:12, Ilya Sherman wrote:
> You can omit the control and default groups.  These configs are meant to
control
> testing the new behavior.

Done.

[Ilya Sherman, 2015-12-08 21:01:07]

LGTM

[vakh (old account. dont use), 2015-12-08 21:38:21]

The CQ bit was checked by vakh@google.com

[vakh (old account. dont use), 2015-12-08 21:38:22]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1502483002/#ps60001
(title: "Sync'd latest changes from origin/master")

[commit-bot: I haz the power, 2015-12-08 21:44:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502483002/60001

[commit-bot: I haz the power, 2015-12-08 23:18:58]

Description was changed from

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=543161
==========

to

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=543161
==========

[commit-bot: I haz the power, 2015-12-08 23:18:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-08 23:20:07]

Description was changed from

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=543161
==========

to

==========
Add section for SafeBrowsingUpdateFrequency in fieldtrial on win/mac/linux

BUG=543161

Committed: https://crrev.com/900a22e14446afe123e66635fed7cbcb0532cec9
Cr-Commit-Position: refs/heads/master@{#363817}
==========

[commit-bot: I haz the power, 2015-12-08 23:20:08]

Patchset 4 (id:??) landed as
https://crrev.com/900a22e14446afe123e66635fed7cbcb0532cec9
Cr-Commit-Position: refs/heads/master@{#363817}