Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: docs/clang.md

Issue 1502453002: Update some clang plugin documentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/clang.md
diff --git a/docs/clang.md b/docs/clang.md
index 5b5ec9060d8af9548c6cc0d4ac922628979610f2..15bf264fe6a360e50d9a6a75149ad6edc56517c3 100644
--- a/docs/clang.md
+++ b/docs/clang.md
@@ -51,11 +51,17 @@ is used by default when clang is used.
If you're working on the plugin, you can build it locally like so:
-1. Run `./tools/clang/scripts/update.sh --force-local-build --without-android`
+1. Run `./tools/clang/scripts/update.py --force-local-build --without-android`
to build the plugin.
-1. Build with clang like described above.
+1. Run `ninja -C third_party/llvm-build/Release+Asserts/` to build incrementally.
+1. Build with clang like described above, but, if you use goma, disable it.
+
+To test the FindBadConstructs plugin, run:
+
+ (cd tools/clang/plugins/tests && \
+ ./test.sh ../../../../third_party/llvm-build/Release+Asserts/bin/clang \
+ ../../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so)
-TODO: writing_clang_plugins does not exist.
To run [other plugins](writing_clang_plugins.md), add these to your
`GYP_DEFINES`:
« no previous file with comments | « no previous file | tools/clang/plugins/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698