Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1502383003: [DevTools] Reset tooltip on resize. (Closed)

Created:
5 years ago by dgozman
Modified:
5 years ago
Reviewers:
samli, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Reset tooltip on resize. This prevents body being scrolled because of absoultely positioned tooltip. BUG=567454 Committed: https://crrev.com/27f8f7ebed3178e4e2d825a40948904d9cf42750 Cr-Commit-Position: refs/heads/master@{#363733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Tooltip.js View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
PTAL
5 years ago (2015-12-08 01:51:48 UTC) #2
pfeldman
lgtm
5 years ago (2015-12-08 02:03:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502383003/1
5 years ago (2015-12-08 02:47:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 04:15:31 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-08 04:16:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/27f8f7ebed3178e4e2d825a40948904d9cf42750
Cr-Commit-Position: refs/heads/master@{#363733}

Powered by Google App Engine
This is Rietveld 408576698