Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1502373003: Enable Control Flow Integrity for the official Linux Chrome. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Control Flow Integrity for the official Linux Chrome. This CL turns on CFI, a security check: https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity http://clang.llvm.org/docs/ControlFlowIntegrity.html This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x. CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%, and should not be an issue. BUG=chromium:464797 Intent to Implement thread: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ This is a third attempt to land the CL. Previous attempts: https://codereview.chromium.org/1501593003/ https://codereview.chromium.org/1393283005/ All issues discovered by the previous attempt are resolved at this point. Committed: https://crrev.com/2e8ed4750b26923558b4754de4fd7f4cae3399e8 Cr-Commit-Position: refs/heads/master@{#363677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
krasin
Hi Nico, our awesome infra team has increased the amount of RAM on the buildbot ...
5 years ago (2015-12-07 21:26:47 UTC) #2
Nico
lgtm
5 years ago (2015-12-07 21:27:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502373003/1
5 years ago (2015-12-07 21:31:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-08 00:41:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502373003/1
5 years ago (2015-12-08 00:47:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 01:20:12 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e8ed4750b26923558b4754de4fd7f4cae3399e8 Cr-Commit-Position: refs/heads/master@{#363677}
5 years ago (2015-12-08 01:21:48 UTC) #12
Mike West
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1502133004/ by mkwst@chromium.org. ...
5 years ago (2015-12-08 09:53:05 UTC) #13
krasin
5 years ago (2015-12-08 19:29:54 UTC) #15
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698