Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1502353004: Remove usage of deprecated APIs from api interceptor tests (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove usage of deprecated APIs from api interceptor tests BUG=v8:4341 R=vogelheim@chromium.org LOG=y NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/4b3239107abd431dec209915ccb6dbc816cda00b Cr-Commit-Position: refs/heads/master@{#32676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+972 lines, -470 lines) Patch
M test/cctest/test-api-interceptors.cc View 152 chunks +972 lines, -470 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-08 12:54:58 UTC) #1
vogelheim
lgtm
5 years ago (2015-12-08 13:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502353004/1
5 years ago (2015-12-08 13:24:55 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/248)
5 years ago (2015-12-08 13:54:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502353004/1
5 years ago (2015-12-08 16:08:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502353004/1
5 years ago (2015-12-08 17:13:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502353004/1
5 years ago (2015-12-08 18:38:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 18:38:43 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-08 18:39:37 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b3239107abd431dec209915ccb6dbc816cda00b
Cr-Commit-Position: refs/heads/master@{#32676}

Powered by Google App Engine
This is Rietveld 408576698