Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1502343009: X87: [runtime] [proxy] Implementing [[Call]]. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] [proxy] Implementing [[Call]]. port 72994124733215c15ff0022616949a2291f3c26c(r32675) original commit message: BUG= Committed: https://crrev.com/6fbd4240fbb849cc87c701a50e42a50e59ba9f8f Cr-Commit-Position: refs/heads/master@{#32686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
zhengxing.li
5 years ago (2015-12-09 01:38:44 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-09 02:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502343009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502343009/1
5 years ago (2015-12-09 02:27:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 03:16:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6fbd4240fbb849cc87c701a50e42a50e59ba9f8f Cr-Commit-Position: refs/heads/master@{#32686}
5 years ago (2015-12-09 03:17:15 UTC) #8
Camillo Bruni
thanks for catching that :)
5 years ago (2015-12-09 09:36:39 UTC) #9
zhengxing.li
5 years ago (2015-12-09 12:56:27 UTC) #10
Message was sent while issue was closed.
On 2015/12/09 09:36:39, cbruni wrote:
> thanks for catching that :)

Welcomed, :)

Powered by Google App Engine
This is Rietveld 408576698