Issue 1502343007: XFA: Hide xfa targets in gyp (similar to GN)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1502343007: XFA: Hide xfa targets in gyp (similar to GN) (Closed)

Created:
5 years ago by Tom Sepez

Modified:
5 years ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

XFA: Hide xfa targets in gyp (similar to GN) Allows "all" to include pdfium:* once again, since targets that don't exist except under xfa are hidden. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0f05b1c9c19e9f45135bb3dd21044b2e69fe086a

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -21 lines)			Patch
	M	build/all.gyp	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	pdfium.gyp	View		2 chunks	+24 lines, -18 lines	0 comments	Download

Total messages: 6 (3 generated)

Tom Sepez

5 years ago (2015-12-09 00:19:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f05b1c9c19e9f45135bb3dd21044b2e69fe086a (presubmit successful).