Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: scripts/slave/recipe_modules/gpu/api.py

Issue 1502313004: (Re-land) Switch GPU FYI bots to new Telemetry GPU isolate. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 from recipe_engine import recipe_api 6 from recipe_engine import recipe_api
7 7
8 import common 8 import common
9 9
10 SIMPLE_TESTS_TO_RUN = freeze([ 10 SIMPLE_TESTS_TO_RUN = freeze([
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
593 if self.m.platform.is_mac and not self.m.tryserver.is_tryserver: 593 if self.m.platform.is_mac and not self.m.tryserver.is_tryserver:
594 #TODO(zmo): remove the vmodule flag after crbug.com/424024 is fixed. 594 #TODO(zmo): remove the vmodule flag after crbug.com/424024 is fixed.
595 vmodules = [ 595 vmodules = [
596 'startup_browser_creator=2' 596 'startup_browser_creator=2'
597 ] 597 ]
598 extra_browser_args_string += ' --vmodule=' + ','.join(vmodules) 598 extra_browser_args_string += ' --vmodule=' + ','.join(vmodules)
599 if extra_browser_args: 599 if extra_browser_args:
600 extra_browser_args_string += ' ' + ' '.join(extra_browser_args) 600 extra_browser_args_string += ' ' + ' '.join(extra_browser_args)
601 test_args.append(extra_browser_args_string) 601 test_args.append(extra_browser_args_string)
602 602
603 return self.m.chromium_tests.steps.TelemetryGPUTest( 603 # Run the new Telemetry GPU test isolate on the FYI waterfall.
604 name, chrome_revision, webkit_revision, args=test_args, 604 # Once it's running well on all platforms, the old isolate, and
605 target_name=target_name, enable_swarming=enable_swarming, 605 # the code which launches it, will be removed.
606 swarming_dimensions=swarming_dimensions, 606 if self.is_fyi_waterfall:
607 master_class_name=self._master_class_name_for_testing, 607 # The step name must end in 'test' or 'tests' in order for the
608 swarming_extra_suffix=self._get_gpu_suffix(swarming_dimensions)) 608 # results to automatically show up on the flakiness dashboard.
609 # (At least, this was true some time ago.) Continue to use this
610 # naming convention for the time being to minimize changes.
611 step_name = name
612 if not (step_name.endswith('test') or step_name.endswith('tests')):
613 step_name = '%s_tests' % step_name
614 # Prepend Telemetry GPU-specific flags.
615 benchmark_name = target_name or name
616 prefix_args = [
617 benchmark_name, '--show-stdout',
618 '--browser=%s' % self.m.chromium.c.build_config_fs.lower() ]
619 return self.m.chromium_tests.steps.LocalIsolatedScriptTest(
620 step_name, args=prefix_args + test_args,
621 target_name='telemetry_gpu_new_test',
622 override_compile_targets=['telemetry_gpu_new_test_run'])
623 else:
624 return self.m.chromium_tests.steps.TelemetryGPUTest(
625 name, chrome_revision, webkit_revision, args=test_args,
626 target_name=target_name, enable_swarming=enable_swarming,
627 swarming_dimensions=swarming_dimensions,
628 master_class_name=self._master_class_name_for_testing,
629 swarming_extra_suffix=self._get_gpu_suffix(swarming_dimensions))
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/gpu/build_and_test.expected/killall_gnome_keyring_failure.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698