Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4295)

Unified Diff: chrome/browser/sync_file_system/drive_metadata_store.cc

Issue 15023022: Add to be fetched files instead of DriveMetadataStore.batch_sync_origins_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tzik review #4 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_metadata_store.cc
diff --git a/chrome/browser/sync_file_system/drive_metadata_store.cc b/chrome/browser/sync_file_system/drive_metadata_store.cc
index b85e5b5a94c08bdf3564ca05b1ab8a4ae4b0188a..687d536b0e07f679c6fdc609d14ea557b05bea46 100644
--- a/chrome/browser/sync_file_system/drive_metadata_store.cc
+++ b/chrome/browser/sync_file_system/drive_metadata_store.cc
@@ -536,11 +536,13 @@ bool DriveMetadataStore::IsOriginDisabled(const GURL& origin) const {
void DriveMetadataStore::AddBatchSyncOrigin(const GURL& origin,
const std::string& resource_id) {
DCHECK(CalledOnValidThread());
- DCHECK(!IsBatchSyncOrigin(origin));
DCHECK(!IsIncrementalSyncOrigin(origin));
DCHECK(!IsOriginDisabled(origin));
DCHECK_EQ(SYNC_STATUS_OK, db_status_);
+ if (IsBatchSyncOrigin(origin))
+ return;
+
batch_sync_origins_.insert(std::make_pair(origin, resource_id));
origin_by_resource_id_.insert(std::make_pair(resource_id, origin));
@@ -586,8 +588,8 @@ void DriveMetadataStore::EnableOrigin(
std::string resource_id = found->second;
disabled_origins_.erase(found);
- // Ensure |origin| is marked as a batch sync origin.
- batch_sync_origins_.insert(std::make_pair(origin, resource_id));
+ // |Origin| goes back to DriveFileSyncService.pending_batch_sync_origins_
+ // only and is not stored in drive_metadata_store.
found = incremental_sync_origins_.find(origin);
if (found != incremental_sync_origins_.end())
incremental_sync_origins_.erase(found);

Powered by Google App Engine
This is Rietveld 408576698