Changing the equation of computing sigma from blur radius

Changing the equation of computing sigma from blur radius

This is implemented in skBlurRadiusToSigma, the equation
is: sigma = factor*radius + 0.5. The number 0.5 does not
make sense and this CL removes it. But that means this CL
will change the blur kernel, which results in NeedsRebaseline
for ~100 layout tests.

BUG=503626
Committed: https://crrev.com/8370a4fbe511ecc3a638f1448843015ae92160ca
Cr-Commit-Position: refs/heads/master@{#364124}

[xidachen, 2015-12-07 20:28:23]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2015-12-07 20:28:23]

PTAL

[xidachen, 2015-12-07 20:36:52]

Description was changed from

==========
Adding a special case handle for SkDropShadowImageFilter

When the shadowBlur parameter is 0, the sigma that provided to the
creation of SkDropShadowImageFilter should be 0, but now it is 0.5, which
causes the failure of virtual/gpu/fast/canvas/canvas-filter-shadow.html

BUG=503626
==========

to

==========
Adding a special case handle for skBlurRadiusToSigma

When the radius parameter is 0, the sigma that provided to 
the creation of SkDropShadowImageFilter should be 0, but 
now it is 0.5, which causes the failure of
virtual/gpu/fast/canvas/canvas-filter-shadow.html

BUG=503626
==========

[Justin Novosad, 2015-12-07 20:39:50]

Description was changed from

==========
Adding a special case handle for skBlurRadiusToSigma

When the radius parameter is 0, the sigma that provided to 
the creation of SkDropShadowImageFilter should be 0, but 
now it is 0.5, which causes the failure of
virtual/gpu/fast/canvas/canvas-filter-shadow.html

BUG=503626
==========

to

==========
Adding a special case for blur radii of 0 in skBlurRadiusToSigma

When the radius parameter is 0, the sigma that provided to 
the creation of SkDropShadowImageFilter should be 0, but 
now it is 0.5, which causes the failure of
virtual/gpu/fast/canvas/canvas-filter-shadow.html

BUG=503626
==========

[Justin Novosad, 2015-12-07 20:39:56]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-12-07 20:40:04]

On 2015/12/07 20:28:23, xidachen wrote:
> PTAL

lgtm

[commit-bot: I haz the power, 2015-12-07 20:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502283002/20001

[commit-bot: I haz the power, 2015-12-07 22:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 22:22:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xidachen, 2015-12-09 17:47:14]

Description was changed from

==========
Adding a special case for blur radii of 0 in skBlurRadiusToSigma

When the radius parameter is 0, the sigma that provided to 
the creation of SkDropShadowImageFilter should be 0, but 
now it is 0.5, which causes the failure of
virtual/gpu/fast/canvas/canvas-filter-shadow.html

BUG=503626
==========

to

==========
Changing the equation of computing sigma from blur radius

This is implemented in skBlurRadiusToSigma, the equation 
is: sigma = factor*radius + 0.5. The number 0.5 does not
make sense and this CL removes it. But that means this CL
will change the blur kernel, which results in NeedsRebaseline
for ~100 layout tests.

BUG=503626
==========

[xidachen, 2015-12-09 18:03:02]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2015-12-09 18:03:03]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1502283002/#ps180001
(title: "update test expectations on mac")

[commit-bot: I haz the power, 2015-12-09 18:07:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502283002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502283002/180001

[commit-bot: I haz the power, 2015-12-09 19:24:19]

Description was changed from

==========
Changing the equation of computing sigma from blur radius

This is implemented in skBlurRadiusToSigma, the equation 
is: sigma = factor*radius + 0.5. The number 0.5 does not
make sense and this CL removes it. But that means this CL
will change the blur kernel, which results in NeedsRebaseline
for ~100 layout tests.

BUG=503626
==========

to

==========
Changing the equation of computing sigma from blur radius

This is implemented in skBlurRadiusToSigma, the equation 
is: sigma = factor*radius + 0.5. The number 0.5 does not
make sense and this CL removes it. But that means this CL
will change the blur kernel, which results in NeedsRebaseline
for ~100 layout tests.

BUG=503626
==========

[commit-bot: I haz the power, 2015-12-09 19:24:20]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-12-09 19:25:57]

Description was changed from

==========
Changing the equation of computing sigma from blur radius

This is implemented in skBlurRadiusToSigma, the equation 
is: sigma = factor*radius + 0.5. The number 0.5 does not
make sense and this CL removes it. But that means this CL
will change the blur kernel, which results in NeedsRebaseline
for ~100 layout tests.

BUG=503626
==========

to

==========
Changing the equation of computing sigma from blur radius

This is implemented in skBlurRadiusToSigma, the equation
is: sigma = factor*radius + 0.5. The number 0.5 does not
make sense and this CL removes it. But that means this CL
will change the blur kernel, which results in NeedsRebaseline
for ~100 layout tests.

BUG=503626

Committed: https://crrev.com/8370a4fbe511ecc3a638f1448843015ae92160ca
Cr-Commit-Position: refs/heads/master@{#364124}
==========

[commit-bot: I haz the power, 2015-12-09 19:25:58]

Patchset 10 (id:??) landed as
https://crrev.com/8370a4fbe511ecc3a638f1448843015ae92160ca
Cr-Commit-Position: refs/heads/master@{#364124}