Build the new Telemetry GPU test isolate on the FYI waterfall.

Build the new Telemetry GPU test isolate on the FYI waterfall.

The FYI bots will be switched over to the new isolate once this
propagates to all the bots.

BUG=561863
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297863

[Ken Russell (switch to Gerrit), 2015-12-07 18:55:54]

kbr@chromium.org changed reviewers:
+ bajones@chromium.org, jmadill@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2015-12-07 18:55:55]

Please review. Thanks.

[bajones, 2015-12-07 19:02:14]

LGTM with one request.

https://codereview.chromium.org/1502273002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/gpu/common.py (right):

https://codereview.chromium.org/1502273002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/gpu/common.py:24: 'telemetry_gpu_new_test',
Silly nit: "new_test" seems very non-descript and is guaranteed to be a misnomer
in time. If there's not an obviously better title I'd prefer even just a
version: telemetry_gpu_2_test?

[Ken Russell (switch to Gerrit), 2015-12-07 19:03:25]

https://codereview.chromium.org/1502273002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/gpu/common.py (right):

https://codereview.chromium.org/1502273002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/gpu/common.py:24: 'telemetry_gpu_new_test',
On 2015/12/07 19:02:14, bajones wrote:
> Silly nit: "new_test" seems very non-descript and is guaranteed to be a
misnomer
> in time. If there's not an obviously better title I'd prefer even just a
> version: telemetry_gpu_2_test?

The new target name is only temporary and isn't trivial to change (requires a
Chromium-side change). Once this switchover is complete, the _new one will be
removed. So I'd like to leave this as is for the moment.

[Ken Russell (switch to Gerrit), 2015-12-07 19:03:28]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2015-12-07 19:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502273002/1

[commit-bot: I haz the power, 2015-12-07 19:05:48]

Description was changed from

==========
Build the new Telemetry GPU test isolate on the FYI waterfall.

The FYI bots will be switched over to the new isolate once this
propagates to all the bots.

BUG=561863
==========

to

==========
Build the new Telemetry GPU test isolate on the FYI waterfall.

The FYI bots will be switched over to the new isolate once this
propagates to all the bots.

BUG=561863

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297863
==========

[commit-bot: I haz the power, 2015-12-07 19:05:49]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297863

[Ken Russell (switch to Gerrit), 2015-12-07 20:50:46]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1504213002/ by kbr@chromium.org.

The reason for reverting is: Broke the FYI bots. New isolate was not supposed to
be run as its own step.
.