Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1502253002: Revert "Copy entire api-docs directory to release GCloud directory in promote script." (Closed)

Created:
5 years ago by Bill Hesse
Modified:
5 years ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Copy entire api-docs directory to release GCloud directory in promote script." This reverts commit f03279a7eb02ceaac7734c623449e8646cc32664. When there is only one file in the directory, this does not move the file into the target directory, but moves it to replace the target directory with a file. Reverting to the old behavior, with a changed filename, since we are now only copying one file. tools/bots/bot_utils.py:124 is changed to use dartdocs_zipfilename() instead of the deleted apidocs_zipfilename(). BUG=https://github.com/dart-lang/www.dartlang.org/issues/1528 R=ricow@google.com Committed: https://github.com/dart-lang/sdk/commit/ed9bb160de5fd16d14e916acca7e7b946ed4470c

Patch Set 1 #

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/bots/bot_utils.py View 1 3 chunks +5 lines, -4 lines 0 comments Download
M tools/promote.py View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
5 years ago (2015-12-07 17:51:22 UTC) #2
ricow1
lgtm
5 years ago (2015-12-08 07:08:05 UTC) #3
Bill Hesse
5 years ago (2015-12-09 09:29:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ed9bb160de5fd16d14e916acca7e7b946ed4470c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698