Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/compiler/test-run-bytecode-graph-builder.cc

Issue 1502243002: [Interpreter] Local flow control in the bytecode graph builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Incorporate comments by mstarzinger on patchet 10. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/control-flow-builders.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-bytecode-graph-builder.cc
diff --git a/test/cctest/compiler/test-run-bytecode-graph-builder.cc b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
index e4fd26754cc57518a8497b18770fed51d3a338d1..3de904304321aca96a86be2e854275f6f0dcc631 100644
--- a/test/cctest/compiler/test-run-bytecode-graph-builder.cc
+++ b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
@@ -1448,6 +1448,396 @@ TEST(BytecodeGraphBuilderObjectLiterals) {
}
}
+
+TEST(BytecodeGraphBuilderIf) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ ExpectedSnippet<1> snippets[] = {
+ {"if (p1 > 1) return 1;\n"
+ "return -1;",
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(2)}},
+ {"if (p1 > 1) return 1;\n"
+ "return -1;",
+ {factory->NewNumberFromInt(-1), factory->NewNumberFromInt(1)}},
+ {"if (p1 > 1) { return 1; } else { return -1; }",
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(2)}},
+ {"if (p1 > 1) { return 1; } else { return -1; }",
+ {factory->NewNumberFromInt(-1), factory->NewNumberFromInt(1)}},
+ {"if (p1 > 50) {\n"
+ " return 1;\n"
+ "} else if (p1 < 10) {\n"
+ " return 10;\n"
+ "} else {\n"
+ " return -10;\n"
+ "}",
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(51)}},
+ {"if (p1 > 50) {\n"
+ " return 1;\n"
+ "} else if (p1 < 10) {\n"
+ " return 10;\n"
+ "} else {\n"
+ " return 100;\n"
+ "}",
+ {factory->NewNumberFromInt(10), factory->NewNumberFromInt(9)}},
+ {"if (p1 > 50) {\n"
+ " return 1;\n"
+ "} else if (p1 < 10) {\n"
+ " return 10;\n"
+ "} else {\n"
+ " return 100;\n"
+ "}",
+ {factory->NewNumberFromInt(100), factory->NewNumberFromInt(10)}},
+ {"if (p1 >= 0) {\n"
+ " if (p1 > 10) { return 2; } else { return 1; }\n"
+ "} else {\n"
+ " if (p1 < -10) { return -2; } else { return -1; }\n"
+ "}",
+ {factory->NewNumberFromInt(2), factory->NewNumberFromInt(100)}},
+ {"if (p1 >= 0) {\n"
+ " if (p1 > 10) { return 2; } else { return 1; }\n"
+ "} else {\n"
+ " if (p1 < -10) { return -2; } else { return -1; }\n"
+ "}",
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(10)}},
+ {"if (p1 >= 0) {\n"
+ " if (p1 > 10) { return 2; } else { return 1; }\n"
+ "} else {\n"
+ " if (p1 < -10) { return -2; } else { return -1; }\n"
+ "}",
+ {factory->NewNumberFromInt(-2), factory->NewNumberFromInt(-11)}},
+ {"if (p1 >= 0) {\n"
+ " if (p1 > 10) { return 2; } else { return 1; }\n"
+ "} else {\n"
+ " if (p1 < -10) { return -2; } else { return -1; }\n"
+ "}",
+ {factory->NewNumberFromInt(-1), factory->NewNumberFromInt(-10)}},
+ };
+
+ size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
+ for (size_t i = 0; i < num_snippets; i++) {
+ ScopedVector<char> script(2048);
+ SNPrintF(script, "function %s(p1) { %s };\n%s(0);", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<Handle<Object>>();
+ Handle<Object> return_value =
+ callable(snippets[i].parameter(0)).ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
+
+TEST(BytecodeGraphBuilderConditionalOperator) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ ExpectedSnippet<1> snippets[] = {
+ {"return (p1 > 1) ? 1 : -1;",
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(2)}},
+ {"return (p1 > 1) ? 1 : -1;",
+ {factory->NewNumberFromInt(-1), factory->NewNumberFromInt(0)}},
+ {"return (p1 > 50) ? 1 : ((p1 < 10) ? 10 : -10);",
+ {factory->NewNumberFromInt(10), factory->NewNumberFromInt(2)}},
+ {"return (p1 > 50) ? 1 : ((p1 < 10) ? 10 : -10);",
+ {factory->NewNumberFromInt(-10), factory->NewNumberFromInt(20)}},
+ };
+
+ size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
+ for (size_t i = 0; i < num_snippets; i++) {
+ ScopedVector<char> script(2048);
+ SNPrintF(script, "function %s(p1) { %s };\n%s(0);", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<Handle<Object>>();
+ Handle<Object> return_value =
+ callable(snippets[i].parameter(0)).ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
+
+TEST(BytecodeGraphBuilderSwitch) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ const char* switch_code =
+ "switch (p1) {\n"
+ " case 1: return 0;\n"
+ " case 2: return 1;\n"
+ " case 3:\n"
+ " case 4: return 2;\n"
+ " case 9: break;\n"
+ " default: return 3;\n"
+ "}\n"
+ "return 9;";
+
+ ExpectedSnippet<1> snippets[] = {
+ {switch_code,
+ {factory->NewNumberFromInt(0), factory->NewNumberFromInt(1)}},
+ {switch_code,
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(2)}},
+ {switch_code,
+ {factory->NewNumberFromInt(2), factory->NewNumberFromInt(3)}},
+ {switch_code,
+ {factory->NewNumberFromInt(2), factory->NewNumberFromInt(4)}},
+ {switch_code,
+ {factory->NewNumberFromInt(9), factory->NewNumberFromInt(9)}},
+ {switch_code,
+ {factory->NewNumberFromInt(3), factory->NewNumberFromInt(5)}},
+ {switch_code,
+ {factory->NewNumberFromInt(3), factory->NewNumberFromInt(6)}},
+ };
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ ScopedVector<char> script(2048);
+ SNPrintF(script, "function %s(p1) { %s };\n%s(0);", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<Handle<Object>>();
+ Handle<Object> return_value =
+ callable(snippets[i].parameter(0)).ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
+
+TEST(BytecodeGraphBuilderNestedSwitch) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ const char* switch_code =
+ "switch (p1) {\n"
+ " case 0: {"
+ " switch (p2) { case 0: return 0; case 1: return 1; case 2: break; }\n"
+ " return -1;"
+ " }\n"
+ " case 1: {"
+ " switch (p2) { case 0: return 2; case 1: return 3; }\n"
+ " }\n"
+ " case 2: break;"
+ " }\n"
+ "return -2;";
+
+ ExpectedSnippet<2> snippets[] = {
+ {switch_code,
+ {factory->NewNumberFromInt(0), factory->NewNumberFromInt(0),
+ factory->NewNumberFromInt(0)}},
+ {switch_code,
+ {factory->NewNumberFromInt(1), factory->NewNumberFromInt(0),
+ factory->NewNumberFromInt(1)}},
+ {switch_code,
+ {factory->NewNumberFromInt(-1), factory->NewNumberFromInt(0),
+ factory->NewNumberFromInt(2)}},
+ {switch_code,
+ {factory->NewNumberFromInt(-1), factory->NewNumberFromInt(0),
+ factory->NewNumberFromInt(3)}},
+ {switch_code,
+ {factory->NewNumberFromInt(2), factory->NewNumberFromInt(1),
+ factory->NewNumberFromInt(0)}},
+ {switch_code,
+ {factory->NewNumberFromInt(3), factory->NewNumberFromInt(1),
+ factory->NewNumberFromInt(1)}},
+ {switch_code,
+ {factory->NewNumberFromInt(-2), factory->NewNumberFromInt(1),
+ factory->NewNumberFromInt(2)}},
+ {switch_code,
+ {factory->NewNumberFromInt(-2), factory->NewNumberFromInt(2),
+ factory->NewNumberFromInt(0)}},
+ };
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ ScopedVector<char> script(2048);
+ SNPrintF(script, "function %s(p1, p2) { %s };\n%s(0, 0);", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<Handle<Object>, Handle<Object>>();
+ Handle<Object> return_value =
+ callable(snippets[i].parameter(0), snippets[i].parameter(1))
+ .ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
+
+TEST(BytecodeGraphBuilderWhile) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ ExpectedSnippet<0> snippets[] = {
+ {"var x = 1; while (x < 1) { x *= 100; } return x;",
+ {factory->NewNumberFromInt(1)}},
+ {"var x = 1, y = 0; while (x < 7) { y += x * x; x += 1; } return y;",
+ {factory->NewNumberFromInt(91)}},
+ {"var x = 1; while (true) { x += 1; if (x == 10) break; } return x;",
+ {factory->NewNumberFromInt(10)}},
+ {"var x = 1; while (false) { x += 1; } return x;",
+ {factory->NewNumberFromInt(1)}},
+ {"var x = 0;\n"
+ "while (true) {\n"
+ " while (x < 10) {\n"
+ " x = x * x + 1;\n"
+ " }"
+ " x += 1;\n"
+ " break;\n"
+ "}\n"
+ "return x;",
+ {factory->NewNumberFromInt(27)}},
+ {"var x = 1, y = 0;\n"
+ "while (x < 7) {\n"
+ " x += 1;\n"
+ " if (x == 2) continue;\n"
+ " if (x == 3) continue;\n"
+ " y += x * x;\n"
+ " if (x == 4) break;\n"
+ "}\n"
+ "return y;",
+ {factory->NewNumberFromInt(16)}}};
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ ScopedVector<char> script(1024);
+ SNPrintF(script, "function %s() { %s }\n%s();", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<>();
+ Handle<Object> return_value = callable().ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
+
+TEST(BytecodeGraphBuilderDo) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ ExpectedSnippet<0> snippets[] = {
+ {"var x = 1; do { x *= 100; } while (x < 100); return x;",
+ {factory->NewNumberFromInt(100)}},
+ {"var x = 1; do { x = x * x + 1; } while (x < 7) return x;",
+ {factory->NewNumberFromInt(26)}},
+ {"var x = 1; do { x += 1; } while (false); return x;",
+ {factory->NewNumberFromInt(2)}},
+ {"var x = 1, y = 0;\n"
+ "do {\n"
+ " x += 1;\n"
+ " if (x == 2) continue;\n"
+ " if (x == 3) continue;\n"
+ " y += x * x;\n"
+ " if (x == 4) break;\n"
+ "} while (x < 7);\n"
+ "return y;",
+ {factory->NewNumberFromInt(16)}}};
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ ScopedVector<char> script(1024);
+ SNPrintF(script, "function %s() { %s }\n%s();", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<>();
+ Handle<Object> return_value = callable().ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
+
+TEST(BytecodeGraphBuilderFor) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ ExpectedSnippet<0> snippets[] = {
+ {"for (var x = 0;; x = 2 * x + 1) { if (x > 10) return x; }",
+ {factory->NewNumberFromInt(15)}},
+ {"for (var x = 0; true; x = 2 * x + 1) { if (x > 100) return x; }",
+ {factory->NewNumberFromInt(127)}},
+ {"for (var x = 0; false; x = 2 * x + 1) { if (x > 100) return x; } "
+ "return 0;",
+ {factory->NewNumberFromInt(0)}},
+ {"for (var x = 0; x < 200; x = 2 * x + 1) { x = x; } return x;",
+ {factory->NewNumberFromInt(255)}},
+ {"for (var x = 0; x < 200; x = 2 * x + 1) {} return x;",
+ {factory->NewNumberFromInt(255)}},
+ {"var sum = 0;\n"
+ "for (var x = 0; x < 200; x += 1) {\n"
+ " if (x % 2) continue;\n"
+ " if (sum > 10) break;\n"
+ " sum += x;\n"
+ "}\n"
+ "return sum;",
+ {factory->NewNumberFromInt(12)}},
+ {"var sum = 0;\n"
+ "for (var w = 0; w < 2; w++) {\n"
+ " for (var x = 0; x < 200; x += 1) {\n"
+ " if (x % 2) continue;\n"
+ " if (x > 4) break;\n"
+ " sum += x + w;\n"
+ " }\n"
+ "}\n"
+ "return sum;",
+ {factory->NewNumberFromInt(15)}},
+ {"var sum = 0;\n"
+ "for (var w = 0; w < 2; w++) {\n"
+ " if (w == 1) break;\n"
+ " for (var x = 0; x < 200; x += 1) {\n"
+ " if (x % 2) continue;\n"
+ " if (x > 4) break;\n"
+ " sum += x + w;\n"
+ " }\n"
+ "}\n"
+ "return sum;",
+ {factory->NewNumberFromInt(6)}},
+ {"var sum = 0;\n"
+ "for (var w = 0; w < 3; w++) {\n"
+ " if (w == 1) continue;\n"
+ " for (var x = 0; x < 200; x += 1) {\n"
+ " if (x % 2) continue;\n"
+ " if (x > 4) break;\n"
+ " sum += x + w;\n"
+ " }\n"
+ "}\n"
+ "return sum;",
+ {factory->NewNumberFromInt(18)}},
+ {"var sum = 0;\n"
+ "for (var x = 1; x < 10; x += 2) {\n"
+ " for (var y = x; y < x + 2; y++) {\n"
+ " sum += y * y;\n"
+ " }\n"
+ "}\n"
+ "return sum;",
+ {factory->NewNumberFromInt(385)}},
+ };
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ ScopedVector<char> script(1024);
+ SNPrintF(script, "function %s() { %s }\n%s();", kFunctionName,
+ snippets[i].code_snippet, kFunctionName);
+
+ BytecodeGraphTester tester(isolate, zone, script.start());
+ auto callable = tester.GetCallable<>();
+ Handle<Object> return_value = callable().ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].return_value()));
+ }
+}
+
} // namespace compiler
} // namespace internal
} // namespace v8
« no previous file with comments | « src/interpreter/control-flow-builders.cc ('k') | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698