[Interpreter] Local flow control in the bytecode graph builder.

src/interpreter/control-flow-builders.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/control-flow-builders.h"
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
 
@@ skipping 14 matching lines @@
 }
 
 
 void BreakableControlFlowBuilder::EmitJumpIfTrue(
     ZoneVector<BytecodeLabel>* sites) {
   sites->push_back(BytecodeLabel());
   builder()->JumpIfTrue(&sites->back());
 }
 
 
+void BreakableControlFlowBuilder::EmitJumpIfFalse(
+    ZoneVector<BytecodeLabel>* sites) {
+  sites->push_back(BytecodeLabel());
+  builder()->JumpIfFalse(&sites->back());
+}
+
+
 void BreakableControlFlowBuilder::EmitJumpIfUndefined(
     ZoneVector<BytecodeLabel>* sites) {
   sites->push_back(BytecodeLabel());
   builder()->JumpIfUndefined(&sites->back());
 }
 
 
 void BreakableControlFlowBuilder::EmitJumpIfNull(
     ZoneVector<BytecodeLabel>* sites) {
   sites->push_back(BytecodeLabel());
   builder()->JumpIfNull(&sites->back());
 }
 
 
 void BreakableControlFlowBuilder::EmitJump(ZoneVector<BytecodeLabel>* sites,
                                            int index) {
   builder()->Jump(&sites->at(index));
 }
 
 
 void BreakableControlFlowBuilder::EmitJumpIfTrue(
     ZoneVector<BytecodeLabel>* sites, int index) {
   builder()->JumpIfTrue(&sites->at(index));
 }
 
 
+void BreakableControlFlowBuilder::EmitJumpIfFalse(
+    ZoneVector<BytecodeLabel>* sites, int index) {
+  builder()->JumpIfFalse(&sites->at(index));
+}
+
+
 void BreakableControlFlowBuilder::BindLabels(const BytecodeLabel& target,
                                              ZoneVector<BytecodeLabel>* sites) {
   for (size_t i = 0; i < sites->size(); i++) {
     BytecodeLabel& site = sites->at(i);
     builder()->Bind(target, &site);
   }
   sites->clear();
 }
 
 
 LoopBuilder::~LoopBuilder() { DCHECK(continue_sites_.empty()); }
 
 
+void LoopBuilder::LoopEnd() {
+  // Loop must have closed form, ie all loop elements are within the

[rmcilroy, 2015/12/15 17:35:44]

nit - /ie/i.e./

[oth, 2015/12/15 22:42:17]

Done.

+  // loop.
+  DCHECK(loop_header_.is_bound());
+  builder()->Bind(&loop_end_);
+  SetBreakTarget(loop_end_);
+  if (next_.is_bound()) {
+    DCHECK(!condition_.is_bound() || next_.offset() >= condition_.offset());
+    SetContinueTarget(next_);
+  } else {
+    DCHECK(condition_.is_bound());
+    DCHECK_GE(condition_.offset(), loop_header_.offset());
+    DCHECK_LE(condition_.offset(), loop_end_.offset());
+    SetContinueTarget(condition_);
+  }
+}
+
+
 void LoopBuilder::SetContinueTarget(const BytecodeLabel& target) {
   BindLabels(target, &continue_sites_);
 }
 
 
 SwitchBuilder::~SwitchBuilder() {
 #ifdef DEBUG
   for (auto site : case_sites_) {
     DCHECK(site.is_bound());
   }
 #endif
 }
 
 
 void SwitchBuilder::SetCaseTarget(int index) {
   BytecodeLabel& site = case_sites_.at(index);
   builder()->Bind(&site);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8