Chromium Code Reviews

Issue 1502193002: Remove deprecate API usage from more cctests (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove deprecate API usage from more cctests BUG=v8:4134 R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/6150662d891e96c5972700b60fa44e17a3da9aa6 Cr-Commit-Position: refs/heads/master@{#32659}

Patch Set 1 #

Total comments: 2

Patch Set 2 : updats #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Stats (+137 lines, -84 lines)
M test/cctest/compiler/test-code-stub-assembler.cc View 1 chunk +3 lines, -0 lines 0 comments
M test/cctest/test-decls.cc View 14 chunks +65 lines, -49 lines 0 comments
M test/cctest/test-inobject-slack-tracking.cc View 1 chunk +3 lines, -0 lines 0 comments
M test/cctest/test-strings.cc View 13 chunks +66 lines, -35 lines 0 comments

Messages

Total messages: 13 (6 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-07 13:30:03 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/1502193002/diff/1/test/cctest/test-decls.cc File test/cctest/test-decls.cc (right): https://codereview.chromium.org/1502193002/diff/1/test/cctest/test-decls.cc#newcode155 test/cctest/test-decls.cc:155: if (!Script::Compile(context, String::NewFromUtf8(CcTest::isolate(), source, (Total nitpick; and a ...
5 years ago (2015-12-07 13:51:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502193002/20001
5 years ago (2015-12-07 14:59:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/10832) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, ...
5 years ago (2015-12-07 15:02:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502193002/40001
5 years ago (2015-12-07 15:09:14 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-07 15:27:45 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-07 15:28:32 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6150662d891e96c5972700b60fa44e17a3da9aa6
Cr-Commit-Position: refs/heads/master@{#32659}

Powered by Google App Engine