Remove deprecate API usage from more cctests

Remove deprecate API usage from more cctests

BUG=v8:4134
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/6150662d891e96c5972700b60fa44e17a3da9aa6
Cr-Commit-Position: refs/heads/master@{#32659}

[vogelheim, 2015-12-07 13:51:19]

lgtm

https://codereview.chromium.org/1502193002/diff/1/test/cctest/test-decls.cc
File test/cctest/test-decls.cc (right):

https://codereview.chromium.org/1502193002/diff/1/test/cctest/test-decls.cc#n...
test/cctest/test-decls.cc:155: if (!Script::Compile(context,
String::NewFromUtf8(CcTest::isolate(), source,
(Total nitpick; and a purely a matter of style. Feel free to ignore.)

Since the (original) test code is meant to handle both successful and erroneous
compilations, I'd find it slightly more logical/readable if script was a
MaybeLocal. Something like this:


MaybeLocal<Script> script = Script::Compile(...);
if (expectations == EXPECT_ERROR) {
  CHECK(script.IsEmpty();
  return;
}
CHECK(!script.IsEmpty());
... result = script.ToLocalChecked()->Run();

Note that only two lines change vis-a-vis the original code.

https://codereview.chromium.org/1502193002/diff/1/test/cctest/test-decls.cc#n...
test/cctest/test-decls.cc:582: Local<Script> script;
(Same nitpick as above. Also feel free to ignore. :) )

[jochen (gone - plz use gerrit), 2015-12-07 14:59:43]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-12-07 14:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1502193002/#ps20001
(title: "updats")

[commit-bot: I haz the power, 2015-12-07 14:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502193002/20001

[commit-bot: I haz the power, 2015-12-07 15:02:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 15:02:56]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12817)

[jochen (gone - plz use gerrit), 2015-12-07 15:09:10]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-12-07 15:09:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1502193002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2015-12-07 15:09:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502193002/40001

[commit-bot: I haz the power, 2015-12-07 15:27:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-07 15:28:31]

Description was changed from

==========
Remove deprecate API usage from more cctests

BUG=v8:4134
R=vogelheim@chromium.org
LOG=n
==========

to

==========
Remove deprecate API usage from more cctests

BUG=v8:4134
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/6150662d891e96c5972700b60fa44e17a3da9aa6
Cr-Commit-Position: refs/heads/master@{#32659}
==========

[commit-bot: I haz the power, 2015-12-07 15:28:32]

Patchset 3 (id:??) landed as
https://crrev.com/6150662d891e96c5972700b60fa44e17a3da9aa6
Cr-Commit-Position: refs/heads/master@{#32659}