Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1502183007: Extract Local refactoring: provide a linked edit group for the name. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract Local refactoring: provide a linked edit group for the name. This will support in-place rename after extract in IDEA. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b05ae45575a1d939e40b4cefd8a98151cf2463c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 5 chunks +46 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 13 chunks +40 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-08 22:48:13 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-08 23:18:36 UTC) #2
scheglov
5 years ago (2015-12-08 23:27:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b05ae45575a1d939e40b4cefd8a98151cf2463c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698