Error checking to clarify SYSTEMROOT errors

Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds two bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org

Committed: https://crrev.com/5e289be0b06d4781610d16daec9064f6f811ce18
Cr-Commit-Position: refs/heads/master@{#363930}

[brucedawson, 2015-12-07 21:26:28]

Description was changed from

==========
Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment x variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds to bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org
==========

to

==========
Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds two bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org
==========

[brucedawson, 2015-12-07 21:27:30]

This is the tools\gyp fix copied to a new home. This should save somebody from
the cryptic message that you (and many many others) have hit.

[jam, 2015-12-08 17:17:32]

lgtm

[brucedawson, 2015-12-08 18:16:01]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-12-08 18:17:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502183004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502183004/1

[commit-bot: I haz the power, 2015-12-08 18:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 18:50:18]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[brucedawson, 2015-12-08 19:49:14]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2015-12-08 19:50:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502183004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502183004/1

[commit-bot: I haz the power, 2015-12-09 02:29:39]

Description was changed from

==========
Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds two bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org
==========

to

==========
Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds two bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org
==========

[commit-bot: I haz the power, 2015-12-09 02:29:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-09 02:30:38]

Description was changed from

==========
Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds two bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org
==========

to

==========
Error checking to clarify SYSTEMROOT errors

Occasionally developers hit this cryptic error:

Exception: Environment variable "SYSTEMROOT" required to be set to valid path

The error message is well intentioned but inevitably misleading. The problem is
rarely if ever caused by SYSTEMROOT not being set. In the most recent case it
was caused by the "SetEnv.cmd && set" command failing.

This change adds two bits of error checking - checking the error code of the
Popen command, and ensuring that the results coming in to
_ExtractImportantEnvironment are plausible. Both of these checks can detect this
particular error, and one or both of them should detect future problems.

This was initially done for gyp in crrev.com/1501673004, this makes the same fix
for gn builds.

R=jam@chromium.org

Committed: https://crrev.com/5e289be0b06d4781610d16daec9064f6f811ce18
Cr-Commit-Position: refs/heads/master@{#363930}
==========

[commit-bot: I haz the power, 2015-12-09 02:30:38]

Patchset 1 (id:??) landed as
https://crrev.com/5e289be0b06d4781610d16daec9064f6f811ce18
Cr-Commit-Position: refs/heads/master@{#363930}