Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1502173003: When was SkPDiff last used? (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
stephana, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6223 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/common_variables.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 2 chunks +0 lines, -60 lines 0 comments Download
D tools/skpdiff/README View 1 chunk +0 lines, -12 lines 0 comments Download
D tools/skpdiff/SkCLImageDiffer.h View 1 chunk +0 lines, -97 lines 0 comments Download
D tools/skpdiff/SkCLImageDiffer.cpp View 1 chunk +0 lines, -122 lines 0 comments Download
D tools/skpdiff/SkDiffContext.h View 1 chunk +0 lines, -204 lines 0 comments Download
D tools/skpdiff/SkDiffContext.cpp View 1 chunk +0 lines, -429 lines 0 comments Download
D tools/skpdiff/SkDifferentPixelsMetric.h View 1 chunk +0 lines, -50 lines 0 comments Download
D tools/skpdiff/SkDifferentPixelsMetric_cpu.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
D tools/skpdiff/SkDifferentPixelsMetric_opencl.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
D tools/skpdiff/SkImageDiffer.h View 1 chunk +0 lines, -73 lines 0 comments Download
D tools/skpdiff/SkImageDiffer.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/skpdiff/SkPMetric.h View 1 chunk +0 lines, -30 lines 0 comments Download
D tools/skpdiff/SkPMetric.cpp View 1 chunk +0 lines, -471 lines 0 comments Download
D tools/skpdiff/SkPMetricUtil_generated.h View 1 chunk +0 lines, -2586 lines 0 comments Download
D tools/skpdiff/diff_viewer.js View 1 chunk +0 lines, -306 lines 0 comments Download
D tools/skpdiff/generate_pmetric_tables.py View 1 chunk +0 lines, -149 lines 0 comments Download
D tools/skpdiff/skpdiff_main.cpp View 1 chunk +0 lines, -268 lines 0 comments Download
D tools/skpdiff/skpdiff_server.py View 1 chunk +0 lines, -580 lines 0 comments Download
D tools/skpdiff/skpdiff_util.h View 1 chunk +0 lines, -60 lines 0 comments Download
D tools/skpdiff/skpdiff_util.cpp View 1 chunk +0 lines, -208 lines 0 comments Download
D tools/skpdiff/viewer.html View 1 chunk +0 lines, -81 lines 0 comments Download
D tools/skpdiff/viewer_style.css View 1 chunk +0 lines, -173 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502173003/1
5 years ago (2015-12-07 14:57:54 UTC) #2
mtklein_C
All these SkPDiff bugs are assigned to you. Are we keeping it around for some ...
5 years ago (2015-12-07 15:06:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-07 15:10:58 UTC) #6
stephana
On 2015/12/07 15:10:58, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-07 15:42:26 UTC) #7
mtklein_C
OK, I have assigned half to me and half to you.
5 years ago (2015-12-07 15:54:54 UTC) #8
stephana
On 2015/12/07 15:54:54, mtklein_C wrote: > OK, I have assigned half to me and half ...
5 years ago (2015-12-07 21:25:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502173003/1
5 years ago (2015-12-07 21:26:36 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-07 21:27:35 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b5f7d778a10ba70a6a3eb6eb841b540ccf03a117

Powered by Google App Engine
This is Rietveld 408576698