Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1502163002: [debugger] add test case for stepping into string template. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] add test case for stepping into string template. R=jkummerow@chromium.org Committed: https://crrev.com/4ff9bb070b4fc093b8202a8385a08e57ed0485f9 Cr-Commit-Position: refs/heads/master@{#32647}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M test/mjsunit/debug-stepin-builtin-callback-opt.js View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/es6/debug-stepin-string-template.js View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
5 years ago (2015-12-07 09:15:50 UTC) #1
Jakob Kummerow
LGTM with nit https://codereview.chromium.org/1502163002/diff/1/test/mjsunit/es6/debug-stepin-string-template.js File test/mjsunit/es6/debug-stepin-string-template.js (right): https://codereview.chromium.org/1502163002/diff/1/test/mjsunit/es6/debug-stepin-string-template.js#newcode10 test/mjsunit/es6/debug-stepin-string-template.js:10: var break_count = 0; nit: unused ...
5 years ago (2015-12-07 09:20:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502163002/20001
5 years ago (2015-12-07 09:21:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-07 09:40:32 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 09:41:12 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4ff9bb070b4fc093b8202a8385a08e57ed0485f9
Cr-Commit-Position: refs/heads/master@{#32647}

Powered by Google App Engine
This is Rietveld 408576698