Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1502153002: Revert of [Android] Support infobars on native page. (Closed)

Created:
5 years ago by Kibeom Kim (inactive)
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Support infobars on native page. (patchset #5 id:80001 of https://codereview.chromium.org/1435393002/ ) Reason for revert: http://crbug.com/565094 Original issue's description: > [Android] Support infobar on native page. > > Make it possible to show infobars on native pages by repurposing > content's FrameLayout parent also for native pages that infobars > can be attached to. > > BUG=546601, 508307 > > Committed: https://crrev.com/57255e034a04ecec605a89b32cf2703dc3636259 > Cr-Commit-Position: refs/heads/master@{#362632} TBR=newt@chromium.org,dfalcantara@chromium.org,dtrainor@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546601, 508307 Committed: https://crrev.com/6720a7f79f9ba0c870c08c13fd997014068452c0 Cr-Commit-Position: refs/heads/master@{#363418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 14 chunks +31 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Kibeom Kim (inactive)
Created Revert of [Android] Support infobars on native page.
5 years ago (2015-12-07 08:30:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502153002/1
5 years ago (2015-12-07 08:30:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502153002/1
5 years ago (2015-12-07 08:33:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 08:35:16 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-07 08:35:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6720a7f79f9ba0c870c08c13fd997014068452c0
Cr-Commit-Position: refs/heads/master@{#363418}

Powered by Google App Engine
This is Rietveld 408576698