Revert of Enable Control Flow Integrity for the official Linux Chrome.

Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #1 id:1 of https://codereview.chromium.org/1502373003/ )

Reason for revert:
Speculative revert to see if this resolves dependency issues on the official builder.

"""
Huh! It appears that dpkg-shlibdeps (http://man.he.net/man1/dpkg-shlibdeps) takes a look at the undefined symbols in the binary, looks at their version and generates the requirement, like "libdbus-1-3 (>= 1.2.14)". If some code was eliminated due to full-program optimization, the number of undefined symbols could reduce, and the requirement could become weaker, like "libdbus-1-3 (>= 1.1.4)".
"""

BUG=567637
Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
>
> This CL turns on CFI, a security check:
> https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%,
> and should not be an issue.
>
> BUG=chromium:464797
> Intent to Implement thread:
> https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ
>
> This is a third attempt to land the CL. Previous attempts:
> https://codereview.chromium.org/1501593003/
> https://codereview.chromium.org/1393283005/
>
> All issues discovered by the previous attempt are resolved at this point.
>
> Committed: https://crrev.com/2e8ed4750b26923558b4754de4fd7f4cae3399e8
> Cr-Commit-Position: refs/heads/master@{#363677}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
Committed: https://crrev.com/8496468f39f1af06f5f0557b999636928487b421
Cr-Commit-Position: refs/heads/master@{#363778}

[Mike West, 2015-12-08 09:53:06]

Created Revert of Enable Control Flow Integrity for the official Linux Chrome.

[commit-bot: I haz the power, 2015-12-08 09:53:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502133004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502133004/1

[commit-bot: I haz the power, 2015-12-08 09:54:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-08 09:55:35]

Description was changed from

==========
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset
#1 id:1 of https://codereview.chromium.org/1502373003/ )

Reason for revert:
Speculative revert to see if this resolves dependency issues on the official
builder.

"""
Huh! It appears that dpkg-shlibdeps (http://man.he.net/man1/dpkg-shlibdeps)
takes a look at the undefined symbols in the binary, looks at their version and
generates the requirement, like "libdbus-1-3 (>= 1.2.14)". If some code was
eliminated due to full-program optimization, the number of undefined symbols
could reduce, and the requirement could become weaker, like "libdbus-1-3 (>=
1.1.4)".
"""

BUG=567637

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
> 
> This CL turns on CFI, a security check:
>
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
> 
> This feature enables LTO (Link-Time Optimization) builds, which slow down the
linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost
is less than 1%,
> and should not be an issue.
> 
> BUG=chromium:464797
> Intent to Implement thread:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2...
> 
> This is a third attempt to land the CL. Previous attempts:
> https://codereview.chromium.org/1501593003/
> https://codereview.chromium.org/1393283005/
> 
> All issues discovered by the previous attempt are resolved at this point.
> 
> Committed: https://crrev.com/2e8ed4750b26923558b4754de4fd7f4cae3399e8
> Cr-Commit-Position: refs/heads/master@{#363677}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
==========

to

==========
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset
#1 id:1 of https://codereview.chromium.org/1502373003/ )

Reason for revert:
Speculative revert to see if this resolves dependency issues on the official
builder.

"""
Huh! It appears that dpkg-shlibdeps (http://man.he.net/man1/dpkg-shlibdeps)
takes a look at the undefined symbols in the binary, looks at their version and
generates the requirement, like "libdbus-1-3 (>= 1.2.14)". If some code was
eliminated due to full-program optimization, the number of undefined symbols
could reduce, and the requirement could become weaker, like "libdbus-1-3 (>=
1.1.4)".
"""

BUG=567637

Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome.
>
> This CL turns on CFI, a security check:
>
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-i...
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> This feature enables LTO (Link-Time Optimization) builds, which slow down the
linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost
is less than 1%,
> and should not be an issue.
>
> BUG=chromium:464797
> Intent to Implement thread:
>
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2...
>
> This is a third attempt to land the CL. Previous attempts:
> https://codereview.chromium.org/1501593003/
> https://codereview.chromium.org/1393283005/
>
> All issues discovered by the previous attempt are resolved at this point.
>
> Committed: https://crrev.com/2e8ed4750b26923558b4754de4fd7f4cae3399e8
> Cr-Commit-Position: refs/heads/master@{#363677}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797

Committed: https://crrev.com/8496468f39f1af06f5f0557b999636928487b421
Cr-Commit-Position: refs/heads/master@{#363778}
==========

[commit-bot: I haz the power, 2015-12-08 09:55:36]

Patchset 1 (id:??) landed as
https://crrev.com/8496468f39f1af06f5f0557b999636928487b421
Cr-Commit-Position: refs/heads/master@{#363778}

[Nico, 2015-12-08 12:06:18]

Can you post the actual diff of the deps (it's in the compile stdout close
to the error message)? If there are now fewer deps we can just update the
deps expectations. Did this only happen with one of the packager scripts,
or with both? 64-bit only, or 32-bit too?
On Dec 8, 2015 4:55 AM, "commit-bot@chromium.org via codereview.chromium.org"
<reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/8496468f39f1af06f5f0557b999636928487b421
> Cr-Commit-Position: refs/heads/master@{#363778}
>
> https://codereview.chromium.org/1502133004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[krasin, 2015-12-08 17:37:53]

lgtm