Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2456)

Unified Diff: chrome/browser/prerender/prerender_tab_helper.cc

Issue 15021007: Do conservative prerendering based on the LocalPredictor in Dev/Canary. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_tab_helper.cc
===================================================================
--- chrome/browser/prerender/prerender_tab_helper.cc (revision 198752)
+++ chrome/browser/prerender/prerender_tab_helper.cc (working copy)
@@ -8,6 +8,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/time.h"
#include "chrome/browser/predictors/logged_in_predictor_table.h"
+#include "chrome/browser/prerender/prerender_field_trial.h"
#include "chrome/browser/prerender/prerender_histograms.h"
#include "chrome/browser/prerender/prerender_manager.h"
#include "chrome/browser/prerender/prerender_manager_factory.h"
@@ -152,6 +153,8 @@
if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
return;
prerender_manager->MarkWebContentsAsNotPrerendered(web_contents());
+ if (IsLocalPredictorEnabled())
Shishir 2013/05/07 22:57:30 In the previous line you are marking the web_conte
tburkard 2013/05/07 23:21:59 No, this only means that the data currently in the
+ prerender_manager->MaybeUsePrerenderedPage(web_contents(), url);
}
void PrerenderTabHelper::DidCommitProvisionalLoadForFrame(
@@ -172,6 +175,8 @@
if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
return;
prerender_manager->RecordNavigation(validated_url);
+ if (IsLocalPredictorEnabled())
Shishir 2013/05/07 22:57:30 Why are we trying to swap at both start and commit
tburkard 2013/05/07 23:21:59 Some URL changes only show up in one or the other,
Shishir 2013/05/08 20:19:20 Can you mention which ones show up on in only one
tburkard 2013/05/08 20:35:47 Removing these changes in this file altogether, si
+ prerender_manager->MaybeUsePrerenderedPage(web_contents(), validated_url);
}
void PrerenderTabHelper::DidStopLoading(

Powered by Google App Engine
This is Rietveld 408576698