Improve ScriptForbiddenScope handling in cross-threaded code.

Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread.

R=haraken
BUG=

Committed: https://crrev.com/ac80984e24fa520ca86ad9fd0954bd00fbcf075a
Cr-Commit-Position: refs/heads/master@{#363454}

[sof, 2015-12-06 15:36:53]

Description was changed from

==========
Improve ScriptForbiddenScope handling.

For code that is used by multiple threads, avoid the use of manual
adjustment of script forbidden counts depending on whether the code is
being executed by the main thread or not. Introduce
ScriptForbiddenIfMainThreadScope that reliably takes care of the details
instead.

R=
BUG=
==========

to

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread. 

R=
BUG=
==========

[sof, 2015-12-06 16:04:21]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-06 16:04:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502093002/20001

[sof, 2015-12-06 16:04:46]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-12-06 16:04:47]

please take a look.

[commit-bot: I haz the power, 2015-12-06 17:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-06 17:35:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2015-12-06 23:12:28]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-12-06 23:12:28]

LGTM

https://codereview.chromium.org/1502093002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/1502093002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:285:
ScriptForbiddenScope::enter();

Don't we want to use ScriptForbiddenIfMainThreadScope?

[sof, 2015-12-07 05:59:17]

https://codereview.chromium.org/1502093002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/1502093002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:285:
ScriptForbiddenScope::enter();
On 2015/12/06 23:12:28, haraken wrote:
> 
> Don't we want to use ScriptForbiddenIfMainThreadScope?

Not able to a scope object, as the script re-enabling happens in gcEpilogue().

Having ScriptForbiddenIfMainThread::{enter,exit} static methods doesn't add
much, so I left them out.

[haraken, 2015-12-07 06:00:13]

On 2015/12/07 05:59:17, sof wrote:
>
https://codereview.chromium.org/1502093002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):
> 
>
https://codereview.chromium.org/1502093002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:285:
> ScriptForbiddenScope::enter();
> On 2015/12/06 23:12:28, haraken wrote:
> > 
> > Don't we want to use ScriptForbiddenIfMainThreadScope?
> 
> Not able to a scope object, as the script re-enabling happens in gcEpilogue().
> 
> Having ScriptForbiddenIfMainThread::{enter,exit} static methods doesn't add
> much, so I left them out.

ah, makes sense.

[sof, 2015-12-07 06:42:59]

Description was changed from

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread. 

R=
BUG=
==========

to

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread. 

R=haraken
BUG=
==========

[sof, 2015-12-07 06:43:06]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-12-07 06:43:06]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2015-12-07 10:46:55]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-12-07 10:46:55]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1502093002/#ps40001
(title: "rebased up past r363426")

[commit-bot: I haz the power, 2015-12-07 10:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1502093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1502093002/40001

[commit-bot: I haz the power, 2015-12-07 11:56:59]

Description was changed from

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread. 

R=haraken
BUG=
==========

to

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread. 

R=haraken
BUG=
==========

[commit-bot: I haz the power, 2015-12-07 11:57:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-07 11:58:21]

Description was changed from

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread. 

R=haraken
BUG=
==========

to

==========
Improve ScriptForbiddenScope handling in cross-threaded code.

For code that is used by multiple threads, we currently have to resort
to explicit main thread checks and manually adjust script forbidden
counts depending. Introduce ScriptForbiddenIfMainThreadScope that
reliably takes care of the details instead, entering&leaving a script
forbidden scope iff on the main thread.

R=haraken
BUG=

Committed: https://crrev.com/ac80984e24fa520ca86ad9fd0954bd00fbcf075a
Cr-Commit-Position: refs/heads/master@{#363454}
==========

[commit-bot: I haz the power, 2015-12-07 11:58:22]

Patchset 3 (id:??) landed as
https://crrev.com/ac80984e24fa520ca86ad9fd0954bd00fbcf075a
Cr-Commit-Position: refs/heads/master@{#363454}