Re-land "Rename CFWL_Thread classes to ThreadImp"

Re-land "Rename CFWL_Thread classes to ThreadImp"

This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.

BUG=
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/df685030b73074e46d7eb789e13135c52775091f

[Tom Sepez, 2015-12-07 23:21:54]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-12-07 23:21:55]

Lei, for review.  This took some doing. See the diagram in fwl_thread.h.

Here's the best rationale I can provide: 

Imagine XFA and FWL were two separate libraries, where FWL is some widget layer
that can be used for things other than XFA. IFWL_XXX provides an interface
(pimpl) for the FWL library (imagine it is shipped compiled).  CFWL_XXXImp are
the hairy details of FWL we seek to hide via this mechanism.

The inaccurately named CFWL_XXX is the lowest layer in XFA that sits on top of
IFWL_XXX and associates additional XFA specific members with each of the library
classes.

https://codereview.chromium.org/1502063005/diff/20001/xfa/include/fwl/lightwi...
File xfa/include/fwl/lightwidget/theme.h (right):

https://codereview.chromium.org/1502063005/diff/20001/xfa/include/fwl/lightwi...
xfa/include/fwl/lightwidget/theme.h:15: class CFWL_Theme : public
IFWL_ThemeProvider {
yow. its cast to IFWL_ThemeProvider in a few places.

[Lei Zhang, 2015-12-09 03:22:52]

lgtm

https://codereview.chromium.org/1502063005/diff/20001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_appimp.cpp (right):

https://codereview.chromium.org/1502063005/diff/20001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_appimp.cpp:20: return
static_cast<CFWL_AppImp*>(GetImpl())->Initialize();
Do you want to implement IFWL_App::GetAppImpl() so you don't have to do all
these static_casts?

[Tom Sepez, 2015-12-09 19:56:07]

https://codereview.chromium.org/1502063005/diff/20001/xfa/src/fwl/src/core/fw...
File xfa/src/fwl/src/core/fwl_appimp.cpp (right):

https://codereview.chromium.org/1502063005/diff/20001/xfa/src/fwl/src/core/fw...
xfa/src/fwl/src/core/fwl_appimp.cpp:20: return
static_cast<CFWL_AppImp*>(GetImpl())->Initialize();
On 2015/12/09 03:22:52, Lei Zhang wrote:
> Do you want to implement IFWL_App::GetAppImpl() so you don't have to do all
> these static_casts?
That would require putting a 

  class CFWL_AppImp;

into the IFW_App header.  Not sure I want to put more CFWL classses into IFWL
land.

[Tom Sepez, 2015-12-09 19:56:44]

Description was changed from

==========
Re-land "Rename CFWL_Thread classes to ThreadImp"

This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.

BUG=
==========

to

==========
Re-land "Rename CFWL_Thread classes to ThreadImp"

This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.

BUG=
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/df685030b73074e46d7eb789e13135c52775...
==========

[Tom Sepez, 2015-12-09 19:56:45]

Committed patchset #3 (id:40001) manually as
df685030b73074e46d7eb789e13135c52775091f (presubmit successful).