Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1502053003: X87: [debugger] do not predict step in target for liveedit. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [debugger] do not predict step in target for liveedit. port 1e671030b96d48105c00ada463e10d95d73dae24 (r32614) original commit message: BUG= Committed: https://crrev.com/55f78b437126c98d90728dc2abc78d5c43ea639d Cr-Commit-Position: refs/heads/master@{#32641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/debug/x87/debug-x87.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 05:38:45 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 06:29:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502053003/1
5 years ago (2015-12-07 06:29:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 06:48:02 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 06:48:34 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/55f78b437126c98d90728dc2abc78d5c43ea639d
Cr-Commit-Position: refs/heads/master@{#32641}

Powered by Google App Engine
This is Rietveld 408576698