Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1502033002: Revert of [Android] Add a configurable environment for devil/. (RELAND 2) (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add a configurable environment for devil/. (RELAND 2) (patchset #10 id:180001 of https://codereview.chromium.org/1416703003/ ) Reason for revert: crbug.com/566503 Original issue's description: > [Android] Add a configurable environment for devil/. (RELAND 2) > > This is a reland of https://codereview.chromium.org/1399273002 > > BUG=476719 > > Committed: https://crrev.com/0c2a94ab87e6351b924a19932442e85a8f786fa0 > Cr-Commit-Position: refs/heads/master@{#363204} TBR=aiolos@chromium.org,nednguyen@google.com,mikecase@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -750 lines) Patch
M build/android/PRESUBMIT.py View 4 chunks +9 lines, -24 lines 0 comments Download
M build/android/adb_install_apk.py View 2 chunks +0 lines, -4 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/devil/android/battery_utils_test.py View 1 chunk +6 lines, -4 lines 0 comments Download
M build/android/devil/android/device_utils.py View 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 3 chunks +17 lines, -19 lines 0 comments Download
M build/android/devil/android/fastboot_utils_test.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/devil/android/logcat_monitor_test.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/devil/android/md5sum.py View 4 chunks +6 lines, -15 lines 0 comments Download
M build/android/devil/android/md5sum_test.py View 2 chunks +9 lines, -14 lines 0 comments Download
M build/android/devil/android/sdk/aapt.py View 2 chunks +5 lines, -7 lines 0 comments Download
M build/android/devil/android/sdk/adb_wrapper.py View 3 chunks +4 lines, -27 lines 0 comments Download
D build/android/devil/android/sdk/build_tools.py View 1 chunk +0 lines, -51 lines 0 comments Download
M build/android/devil/android/sdk/dexdump.py View 2 chunks +5 lines, -6 lines 0 comments Download
M build/android/devil/android/sdk/fastboot.py View 2 chunks +4 lines, -6 lines 0 comments Download
M build/android/devil/android/sdk/shared_prefs_test.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/devil/android/sdk/split_select.py View 2 chunks +5 lines, -7 lines 0 comments Download
D build/android/devil/devil_dependencies.json View 1 chunk +0 lines, -112 lines 0 comments Download
D build/android/devil/devil_env.py View 1 chunk +0 lines, -138 lines 0 comments Download
D build/android/devil/utils/lazy/__init__.py View 1 chunk +0 lines, -5 lines 0 comments Download
D build/android/devil/utils/lazy/weak_constant.py View 1 chunk +0 lines, -29 lines 0 comments Download
M build/android/devil/utils/lsusb.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/utils/mock_calls.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/devil/utils/mock_calls_test.py View 1 chunk +3 lines, -2 lines 0 comments Download
D build/android/devil_chromium.json View 1 chunk +0 lines, -59 lines 0 comments Download
D build/android/devil_chromium.py View 1 chunk +0 lines, -88 lines 0 comments Download
M build/android/gyp/apk_install.py View 2 chunks +3 lines, -10 lines 0 comments Download
M build/android/gyp/create_device_library_links.py View 2 chunks +1 line, -8 lines 0 comments Download
M build/android/gyp/get_device_configuration.py View 1 chunk +1 line, -12 lines 0 comments Download
M build/android/gyp/push_libraries.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/incremental_install/installer.py View 2 chunks +1 line, -5 lines 0 comments Download
M build/android/provision_devices.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 2 chunks +35 lines, -6 lines 0 comments Download
M build/android/pylib/forwarder.py View 5 chunks +8 lines, -13 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/pylintrc View 1 chunk +0 lines, -4 lines 0 comments Download
M build/android/setup.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.py View 3 chunks +1 line, -18 lines 0 comments Download
M build/android/tombstones.py View 2 chunks +0 lines, -4 lines 0 comments Download
M build/java_apk.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/catapult_base/dependency_manager/cloud_storage_info.py View 2 chunks +1 line, -8 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/android_device.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/android_device_unittest.py View 10 chunks +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/binary_manager.py View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
stevenjb
Created Revert of [Android] Add a configurable environment for devil/. (RELAND 2)
5 years ago (2015-12-06 00:20:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1502033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1502033002/1
5 years ago (2015-12-06 00:21:26 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-06 00:22:41 UTC) #4
Failed to apply patch for build/android/incremental_install/installer.py:
While running git apply --index -3 -p1;
  error: patch failed: build/android/incremental_install/installer.py:255
  Falling back to three-way merge...
  Applied patch to 'build/android/incremental_install/installer.py' with
conflicts.
  U build/android/incremental_install/installer.py

Patch:       build/android/incremental_install/installer.py
Index: build/android/incremental_install/installer.py
diff --git a/build/android/incremental_install/installer.py
b/build/android/incremental_install/installer.py
index
ff6e08e089942a04af1c7f83dce624226d94a655..373889df89d30c7b68b5f652674e148035b8ec81
100755
--- a/build/android/incremental_install/installer.py
+++ b/build/android/incremental_install/installer.py
@@ -14,9 +14,7 @@
 import shutil
 import sys
 
-sys.path.append(
-    os.path.abspath(os.path.join(os.path.dirname(__file__), os.pardir)))
-import devil_chromium
+sys.path.append(os.path.join(os.path.dirname(__file__), os.pardir))
 from devil.android import apk_helper
 from devil.android import device_utils
 from devil.android import device_errors
@@ -255,8 +253,6 @@
   if args.output_directory:
     constants.SetOutputDirectory(args.output_directory)
 
-  devil_chromium.Initialize(output_directory=constants.GetOutputDirectory())
-
   if args.device:
     # Retries are annoying when commands fail for legitimate reasons. Might
want
     # to enable them if this is ever used on bots though.

Powered by Google App Engine
This is Rietveld 408576698