Issue 150203016: Add cross-origin BindingsSecurity checks to 'EventTarget::dispatchEvent'.

Issue 150203016: Add cross-origin BindingsSecurity checks to 'EventTarget::dispatchEvent'. (Closed)

Created:
6 years, 10 months ago by Mike West

Modified:
6 years, 10 months ago

Reviewers:
Nils Barth (inactive), jochen (gone - plz use gerrit)

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add cross-origin BindingsSecurity checks to 'EventTarget::dispatchEvent'. BUG=342618 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166999

Patch Set 1 #

Patch Set 2 : Test. #

Total comments: 1

Patch Set 3 : Doctype + rebaseline. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -5 lines)			Patch
A	LayoutTests/http/tests/security/cross-frame-access-dispatchEvent.html	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/security/cross-frame-access-dispatchEvent-expected.txt	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/bindings/scripts/code_generator_v8.pm	View		3 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/150203016/diff/20001/LayoutTests/http/tests/security/cross-frame-access-dispatchEvent.html File LayoutTests/http/tests/security/cross-frame-access-dispatchEvent.html (right): https://codereview.chromium.org/150203016/diff/20001/LayoutTests/http/tests/security/cross-frame-access-dispatchEvent.html#newcode1 LayoutTests/http/tests/security/cross-frame-access-dispatchEvent.html:1: <html> doctype missing

6 years, 10 months ago (2014-02-12 09:27:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/150203016/90001

6 years, 10 months ago (2014-02-12 09:46:53 UTC) #4

Nils Barth (inactive)

6 years, 10 months ago (2014-02-14 11:29:53 UTC) #6

Message was sent while issue was closed.

Python side at:
IDL compiler: sync Python to r166999
https://codereview.chromium.org/166593002/

Expand Messages | Collapse Messages