ChromeOS: only use CertVerifyProcChromeOS if multiprofiles is allowed.

ChromeOS: only use CertVerifyProcChromeOS if multiprofiles is allowed.

BUG=218627
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250994

[Ryan Sleevi, 2014-02-12 07:06:44]

LGTM mod nits

https://codereview.chromium.org/150203007/diff/40001/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/150203007/diff/40001/chrome/browser/io_thread...
chrome/browser/io_thread.cc:564: #else
I'm wondering whether this should be folded in with the next line

#if defined(OS_CHROMEOS)
if (...) {
   ...
} else
#else
{
  globals_->...
}
#endif

so that the else case and the non-CrOS case use the same path.

[mattm, 2014-02-12 23:25:43]

https://codereview.chromium.org/150203007/diff/40001/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/150203007/diff/40001/chrome/browser/io_thread...
chrome/browser/io_thread.cc:564: #else
On 2014/02/12 07:06:44, Ryan Sleevi wrote:
> I'm wondering whether this should be folded in with the next line
> 
> #if defined(OS_CHROMEOS)
> if (...) {
>    ...
> } else
> #else
> {
>   globals_->...
> }
> #endif
> 
> so that the else case and the non-CrOS case use the same path.

Yeah, I just wasn't sure whether code duplication or control structures that
cross ifdef boundaries is more ugly. I've changed it.

[mattm, 2014-02-12 23:28:16]

+thestig for OWNERS

[Lei Zhang, 2014-02-13 01:38:37]

lgtm

https://codereview.chromium.org/150203007/diff/120001/chrome/browser/io_threa...
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/150203007/diff/120001/chrome/browser/io_threa...
chrome/browser/io_thread.cc:560: } else // Fallthrough to normal verifier if
multiprofiles are not allowed.
You may want // NOLINT here, otherwise presubmit checks will always complain.
Also, two spaces before //

[mattm, 2014-02-13 01:47:19]

https://codereview.chromium.org/150203007/diff/120001/chrome/browser/io_threa...
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/150203007/diff/120001/chrome/browser/io_threa...
chrome/browser/io_thread.cc:560: } else // Fallthrough to normal verifier if
multiprofiles are not allowed.
On 2014/02/13 01:38:38, Lei Zhang wrote:
> You may want // NOLINT here, otherwise presubmit checks will always complain.
> Also, two spaces before //

Thanks, done.

[mattm, 2014-02-13 01:47:33]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-02-13 01:51:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/150203007/260001

[commit-bot: I haz the power, 2014-02-13 03:00:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 03:00:26]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chrome_elf_unittests, chromedriver_unittests, components_unittests,
compositor_unittests, content_browsertests, content_unittests, crypto_unittests,
events_unittests, google_apis_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[mattm, 2014-02-13 03:02:39]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-02-13 03:03:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/150203007/260001

[commit-bot: I haz the power, 2014-02-13 14:42:16]

Change committed as 250994