Issue 15019018: Merge 198829 "Changes the order of widget Close() and DecrementD..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15019018: Merge 198829 "Changes the order of widget Close() and DecrementD..." (Closed)

Created:
7 years, 7 months ago by Jun Mukai

Modified:
7 years, 7 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge 198829 "Changes the order of widget Close() and DecrementD..." > Changes the order of widget Close() and DecrementDeferCounter(). > > This is a bit tricky scenario, but the current code may lead to > a mismatch of increment/decrement by calling Close(). See the bug > for how the mismatch happens. > > BUG=238477 > > Review URL: https://chromiumcodereview.appspot.com/14820016 TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200013

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	ui/message_center/views/toast_contents_view.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r200013.