Issue 15019009: Use either out/Release or out/Debug for YouCompleteMe, depending on mtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15019009: Use either out/Release or out/Debug for YouCompleteMe, depending on mtime. (Closed)

Created:
7 years, 7 months ago by eroman

Modified:
7 years, 7 months ago

Reviewers:
simonjam, James Simonsen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use either out/Release or out/Debug for YouCompleteMe, depending on mtime. R=simonjam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198839

Patch Set 2 : Remove extra space #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
	M	tools/vim/chromium.ycm_extra_conf.py	View	1	3 chunks	+29 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Simonsen

lgtm https://codereview.chromium.org/15019009/diff/1/tools/vim/chromium.ycm_extra_conf.py File tools/vim/chromium.ycm_extra_conf.py (right): https://codereview.chromium.org/15019009/diff/1/tools/vim/chromium.ycm_extra_conf.py#newcode94 tools/vim/chromium.ycm_extra_conf.py:94: rel_mtime = os.path.getmtime(os.path.join(release_path, test_path)) too many spaces before ...

7 years, 7 months ago (2013-05-07 21:33:24 UTC) #2

eroman

https://codereview.chromium.org/15019009/diff/1/tools/vim/chromium.ycm_extra_conf.py File tools/vim/chromium.ycm_extra_conf.py (right): https://codereview.chromium.org/15019009/diff/1/tools/vim/chromium.ycm_extra_conf.py#newcode94 tools/vim/chromium.ycm_extra_conf.py:94: rel_mtime = os.path.getmtime(os.path.join(release_path, test_path)) On 2013/05/07 21:33:24, James Simonsen ...

7 years, 7 months ago (2013-05-08 01:31:07 UTC) #3

eroman

7 years, 7 months ago (2013-05-08 01:46:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r198839 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15019009: Use either out/Release or out/Debug for YouCompleteMe, depending on mtime. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove extra space #

Messages