Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issue 1501873002: Revert of Enable Control Flow Integrity for the official Linux Chrome. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
Reviewers:
Nico, pcc1
CC:
chromium-reviews, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #1 id:1 of https://codereview.chromium.org/1501593003/ ) Reason for revert: Buildbot timed out: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/6284 "command timed out: 3600 seconds without output, attempting to kill" It's hard to say why does the buildbot so much slower than a local build. Possibly, not enough RAM. Original issue's description: > Enable Control Flow Integrity for the official Linux Chrome. > > This CL turns on CFI, a security check: > https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity > http://clang.llvm.org/docs/ControlFlowIntegrity.html > > This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x. > CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%, > and should not be an issue. > > BUG=chromium:464797 > Intent to Implement thread: > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ > > This is a second attempt to land the CL. The first one: > https://codereview.chromium.org/1393283005/ > > Committed: https://crrev.com/abbfcc7930834381e05c31068ac2256cb9ea4f49 > Cr-Commit-Position: refs/heads/master@{#363267} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:464797 Committed: https://crrev.com/931533d38f6b44a56f7a768e91d71f2f167c7897 Cr-Commit-Position: refs/heads/master@{#363313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
krasin
Created Revert of Enable Control Flow Integrity for the official Linux Chrome.
5 years ago (2015-12-05 00:01:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501873002/1
5 years ago (2015-12-05 00:04:06 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-05 00:04:07 UTC) #4
pcc1
lgtm
5 years ago (2015-12-05 00:06:41 UTC) #5
krasin
On 2015/12/05 00:06:41, pcc1 wrote: > lgtm Thank you, Peter!
5 years ago (2015-12-05 00:08:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501873002/1
5 years ago (2015-12-05 00:16:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-05 00:24:44 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-05 00:26:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/931533d38f6b44a56f7a768e91d71f2f167c7897
Cr-Commit-Position: refs/heads/master@{#363313}

Powered by Google App Engine
This is Rietveld 408576698