[Android] Use more specific host platforms for devil.

[Android] Use more specific host platforms for devil.

BUG=566160, 566170
Committed: https://crrev.com/e29693bed4c3a0db11d68ac69ba1131b04661c51
Cr-Commit-Position: refs/heads/master@{#363488}

[jbudorick, 2015-12-04 22:42:26]

jbudorick@chromium.org changed reviewers:
+ aiolos@chromium.org, nednguyen@google.com

[jbudorick, 2015-12-04 22:42:27]

turns out "android_host" was a bad idea.

[aiolos (Not reviewing), 2015-12-04 22:54:58]

On 2015/12/04 22:42:27, jbudorick wrote:
> turns out "android_host" was a bad idea.

Happens. :) lgtm

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_d...
File build/android/devil/devil_dependencies.json (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_d...
build/android/devil/devil_dependencies.json:8: "android_linux2": {
Do we only support android on linux? I though we also supported it on mac for
some reason.

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
File build/android/devil/devil_env.py (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
build/android/devil/devil_env.py:133: arch = device.product_cpu_abi if device
else sys.platform
Does this really return linux2? How odd.

[jbudorick, 2015-12-04 22:59:23]

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_d...
File build/android/devil/devil_dependencies.json (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_d...
build/android/devil/devil_dependencies.json:8: "android_linux2": {
On 2015/12/04 22:54:58, aiolos wrote:
> Do we only support android on linux? I though we also supported it on mac for
> some reason.

I think it's only on linux currently unless you pull in the SDK yourself. I'm
open to adding android_darwin here in a future CL, though.

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
File build/android/devil/devil_env.py (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
build/android/devil/devil_env.py:133: arch = device.product_cpu_abi if device
else sys.platform
On 2015/12/04 22:54:58, aiolos wrote:
> Does this really return linux2? How odd.

before python 3.3, yep: https://docs.python.org/2/library/sys.html#sys.platform

[jbudorick, 2015-12-04 23:03:05]

The CQ bit was checked by jbudorick@chromium.org

[aiolos (Not reviewing), 2015-12-04 23:06:39]

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_d...
File build/android/devil/devil_dependencies.json (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_d...
build/android/devil/devil_dependencies.json:8: "android_linux2": {
On 2015/12/04 22:59:22, jbudorick wrote:
> On 2015/12/04 22:54:58, aiolos wrote:
> > Do we only support android on linux? I though we also supported it on mac
for
> > some reason.
> 
> I think it's only on linux currently unless you pull in the SDK yourself. I'm
> open to adding android_darwin here in a future CL, though.

sounds good.

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
File build/android/devil/devil_env.py (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
build/android/devil/devil_env.py:133: arch = device.product_cpu_abi if device
else sys.platform
On 2015/12/04 22:59:23, jbudorick wrote:
> On 2015/12/04 22:54:58, aiolos wrote:
> > Does this really return linux2? How odd.
> 
> before python 3.3, yep:
https://docs.python.org/2/library/sys.html#sys.platform

huh. The more you know. ;)

[commit-bot: I haz the power, 2015-12-04 23:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501843002/1

[nednguyen, 2015-12-04 23:48:51]

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
File build/android/devil/devil_env.py (right):

https://codereview.chromium.org/1501843002/diff/1/build/android/devil/devil_e...
build/android/devil/devil_env.py:133: arch = device.product_cpu_abi if device
else sys.platform
On 2015/12/04 23:06:39, aiolos wrote:
> On 2015/12/04 22:59:23, jbudorick wrote:
> > On 2015/12/04 22:54:58, aiolos wrote:
> > > Does this really return linux2? How odd.
> > 
> > before python 3.3, yep:
> https://docs.python.org/2/library/sys.html#sys.platform
> 
> huh. The more you know. ;)

I recommend using platform.system() to avoid this ugly problem ~_~

[commit-bot: I haz the power, 2015-12-05 00:29:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 00:29:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aiolos (Not reviewing), 2015-12-05 00:38:40]

On 2015/12/05 00:29:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Try job is failing because it expected there to be a path for adb on mac. One
way to fix that would be to only look for it if on linux, or to put the
FetchPath for it in a try block (dependency_manager.exceptions.NoPathFoundError
is what you would want to catch).

[jbudorick, 2015-12-05 01:04:09]

On 2015/12/05 00:38:40, aiolos wrote:
> On 2015/12/05 00:29:15, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> Try job is failing because it expected there to be a path for adb on mac. One
> way to fix that would be to only look for it if on linux, or to put the
> FetchPath for it in a try block
(dependency_manager.exceptions.NoPathFoundError
> is what you would want to catch).

went with two exceptions; devil shouldn't try to handle the case where it
doesn't have adb, but the dependency manager exception shouldn't be part of
devil's interface, so it raises a new exception specifically for this case.

telemetry will now catch that exception and report itself as unable to find
android devices.

[aiolos (Not reviewing), 2015-12-05 01:06:11]

lgtm

[jbudorick, 2015-12-05 01:07:05]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-12-05 01:08:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501843002/20001

[commit-bot: I haz the power, 2015-12-05 03:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 03:06:56]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[jbudorick, 2015-12-05 03:08:31]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-12-05 03:09:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501843002/20001

[commit-bot: I haz the power, 2015-12-05 05:12:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 05:12:39]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[jbudorick, 2015-12-05 15:57:32]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-12-05 15:58:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501843002/20001

[commit-bot: I haz the power, 2015-12-05 18:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 18:00:07]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[jbudorick, 2015-12-07 14:23:37]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-12-07 14:23:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501843002/20001

[commit-bot: I haz the power, 2015-12-07 15:53:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-07 15:54:23]

Description was changed from

==========
[Android] Use more specific host platforms for devil.

BUG=566160,566170
==========

to

==========
[Android] Use more specific host platforms for devil.

BUG=566160,566170

Committed: https://crrev.com/e29693bed4c3a0db11d68ac69ba1131b04661c51
Cr-Commit-Position: refs/heads/master@{#363488}
==========

[commit-bot: I haz the power, 2015-12-07 15:54:23]

Patchset 2 (id:??) landed as
https://crrev.com/e29693bed4c3a0db11d68ac69ba1131b04661c51
Cr-Commit-Position: refs/heads/master@{#363488}