Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: .gn

Issue 1501823003: Add //ui/* to "gn check" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index 8975f99b5a0991c7019c0ca4f356a76f5740c6cf..331538e710acf21c851f49e250acf4e04f4946c2 100644
--- a/.gn
+++ b/.gn
@@ -84,7 +84,40 @@ check_targets = [
"//third_party/WebKit/Source/*",
"//tools/*",
- #"//ui/*", # Just a few problems.
+ #"//ui/*", # Work left on Chromeos w/ use_ozone. Some parts of UI that work:
+ "//ui/accessibility/*",
+ "//ui/android/*",
+ "//ui/app_list/*",
+ "//ui/aura/*",
+ "//ui/aura_extra/*",
+ "//ui/base/*",
+ "//ui/chromeos/*",
+ "//ui/compositor/*",
+ "//ui/display/*",
+ "//ui/events:events", # Specifically avoid //ui/events/ozone
+ "//ui/events:events_base",
+ "//ui/events:events_unittests",
+ "//ui/file_manager/*",
+ "//ui/gfx/*",
+ "//ui/gl/*",
+ "//ui/keyboard/*",
+ "//ui/login/*",
+ "//ui/message_center/*",
+ "//ui/metro_viewer/*",
+ "//ui/mojo/*",
+ "//ui/native_theme/*",
+ "//ui/platform_window/*",
+ "//ui/resources/*",
+ "//ui/shell_dialogs/*",
+ "//ui/snapshot/*",
+ "//ui/strings/*",
+ "//ui/surface/*",
+ "//ui/touch_selection/*",
+ "//ui/views/*",
+ "//ui/views_content_client/*",
+ "//ui/web_dialogs/*",
+ "//ui/webui/*",
+ "//ui/wm/*",
"//url/*",
"//v8/*",
"//win8/*",
« no previous file with comments | « no previous file | content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698