Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1501823003: Add //ui/* to "gn check" (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, tapted, sadrul, Matt Giuca, tdresser+watch_chromium.org, Ian Vollick, tfarina, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), kalyank, danakj+watch_chromium.org, abarth-chromium, ben+mojo_chromium.org, ozone-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add most of //ui/ to "gn check" Fixes various missing dependencies. In static builds, the //content target now exports content/public/browser, etc. as public dependencies. Add an ipc_param_traits target that allows targets like events/latency_info.h to define IPC traits, without actually linking in all of IPC (because in this case events has no use of IPC). Move some targets to public deps. The rule is that test_support targets should export the corresponding regular target as a public dep so tests don't have to depend on both. Mark a few conditional includes "// nogncheck" where the checker got confused. Fix manifest for views_unittests Committed: https://crrev.com/b7f2c30e4cc7b6c25e348c848af92d173dd3cbaa Cr-Commit-Position: refs/heads/master@{#363690}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -33 lines) Patch
M .gn View 1 2 1 chunk +34 lines, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ipc/BUILD.gn View 4 chunks +14 lines, -2 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/android/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/app_list/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/chromeos/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download
M ui/events/event.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/metro_viewer/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/mojo/geometry/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/mojo/init/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/mojo/init/ui_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/platform_window/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/stub/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 6 chunks +11 lines, -12 lines 0 comments Download
M ui/views/examples/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501823003/1
5 years ago (2015-12-05 01:08:30 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/39020)
5 years ago (2015-12-05 01:18:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501823003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501823003/20001
5 years ago (2015-12-07 19:25:52 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/76757)
5 years ago (2015-12-07 19:46:43 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501823003/40001
5 years ago (2015-12-07 20:20:50 UTC) #13
sky
LGTM
5 years ago (2015-12-07 22:32:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501823003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501823003/40001
5 years ago (2015-12-07 22:40:52 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-08 01:29:28 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-08 01:30:23 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7f2c30e4cc7b6c25e348c848af92d173dd3cbaa
Cr-Commit-Position: refs/heads/master@{#363690}

Powered by Google App Engine
This is Rietveld 408576698