Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issue 1501803002: Remove show clauses for types that moved to other libraries. (Closed)

Created:
5 years ago by Bob Nystrom
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove show clauses for types that moved to other libraries. ConstantEvaluationTarget is now imported from dart.dart and AnalysisException is in java_engine.dart. Committed: https://github.com/dart-lang/sdk/commit/af4d7319fe12144380e24fbc7694fcc07128abd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
I tested this using: ./tools/test.dart -m release -a ia32 pkg/analyzer Is there anything else I ...
5 years ago (2015-12-04 20:42:08 UTC) #2
Bob Nystrom
Committed patchset #1 (id:1) manually as af4d7319fe12144380e24fbc7694fcc07128abd6 (presubmit successful).
5 years ago (2015-12-04 23:50:35 UTC) #4
Bob Nystrom
5 years ago (2015-12-04 23:50:56 UTC) #5
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698