Separate component resources into their own .grd file

Separate component resources into their own .grd file

TBR=ben@chromium.org (gyp changes)
BUG=140037
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199800

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200038

[Cait (Slow), 2013-05-09 22:16:37]

Jói: PTAL at the grit-related changes.
Ben: FYI

Thanks,
Cait

[Jói, 2013-05-10 20:33:25]

LGTM except for question below.

https://codereview.chromium.org/15018020/diff/1/components/component_resource...
File components/component_resources.grd (right):

https://codereview.chromium.org/15018020/diff/1/components/component_resource...
components/component_resources.grd:1: <?xml version="1.0" encoding="utf-8"?>
Shouldn't there be a matching negative change to another .grd file that the
resources in this file are removed from?

[Cait (Slow), 2013-05-10 22:30:38]

https://codereview.chromium.org/15018020/diff/1/components/component_resource...
File components/component_resources.grd (right):

https://codereview.chromium.org/15018020/diff/1/components/component_resource...
components/component_resources.grd:1: <?xml version="1.0" encoding="utf-8"?>
On 2013/05/10 20:33:25, Jói wrote:
> Shouldn't there be a matching negative change to another .grd file that the
> resources in this file are removed from?
Fixed. Some of these strings are still used in chrome/browser/ui and unit_tests,
so I've included the new resource header in those places.

[Jói, 2013-05-11 11:55:47]

LGTM

[commit-bot: I haz the power, 2013-05-13 16:04:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/15018020/10001

[commit-bot: I haz the power, 2013-05-13 19:41:48]

Change committed as 199800

[tonyg, 2013-05-13 21:17:35]

On 2013/05/13 19:41:48, I haz the power (commit-bot) wrote:
> Change committed as 199800

This appears to have broken the mac build on the chromium.perf waterfall. I'm
going to prepare a rollback. See:
http://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/47157...

[tonyg, 2013-05-13 21:24:50]

On 2013/05/13 21:17:35, tonyg wrote:
> On 2013/05/13 19:41:48, I haz the power (commit-bot) wrote:
> > Change committed as 199800
> 
> This appears to have broken the mac build on the chromium.perf waterfall. I'm
> going to prepare a rollback. See:
>
http://build.chromium.org/p/chromium.perf/builders/Mac%2520Builder/builds/471...

Reverted by r199825

[commit-bot: I haz the power, 2013-05-14 16:04:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/15018020/28001

[commit-bot: I haz the power, 2013-05-14 18:36:03]

Change committed as 200038

[tfarina, 2013-06-09 03:57:14]

Joi, Cait, I have been looking into this and I think
components_resources.grd/gyp is misleading. Resources are generally
images/assets and/or html/js/css files and we use IDR_* for them. I'd then name
this autofill_strings.grd/gyp and also move it into components/autofill/strings.
I also note that there isn't a translation section in the grd file and the
corresponding xtb files. What you think?

[Jói, 2013-06-10 11:17:47]

It does seem like _strings.grd would be more consistent naming.  We
should probably switch to that.

There definitely needs to be a translation section, but before we can
switch to that I think we need to have the first set of .xtb files for
this .grd file.  We should set that up once it's been renamed; Cait I
can help you with that once you've renamed.

Cheers,
Jói


On Sun, Jun 9, 2013 at 4:57 AM,  <tfarina@chromium.org> wrote:
> Joi, Cait, I have been looking into this and I think
> components_resources.grd/gyp is misleading. Resources are generally
> images/assets and/or html/js/css files and we use IDR_* for them. I'd then
> name
> this autofill_strings.grd/gyp and also move it into
> components/autofill/strings.
> I also note that there isn't a translation section in the grd file and the
> corresponding xtb files. What you think?
>
> https://codereview.chromium.org/15018020/

[Jói, 2013-06-10 11:29:39]

Actually, Cait:  We need to make sure this gets done before the next
branch point.  Could you open a tracking bug?

On Mon, Jun 10, 2013 at 12:17 PM, Jói Sigurðsson <joi@chromium.org> wrote:
> It does seem like _strings.grd would be more consistent naming.  We
> should probably switch to that.
>
> There definitely needs to be a translation section, but before we can
> switch to that I think we need to have the first set of .xtb files for
> this .grd file.  We should set that up once it's been renamed; Cait I
> can help you with that once you've renamed.
>
> Cheers,
> Jói
>
>
> On Sun, Jun 9, 2013 at 4:57 AM,  <tfarina@chromium.org> wrote:
>> Joi, Cait, I have been looking into this and I think
>> components_resources.grd/gyp is misleading. Resources are generally
>> images/assets and/or html/js/css files and we use IDR_* for them. I'd then
>> name
>> this autofill_strings.grd/gyp and also move it into
>> components/autofill/strings.
>> I also note that there isn't a translation section in the grd file and the
>> corresponding xtb files. What you think?
>>
>> https://codereview.chromium.org/15018020/

[tfarina, 2013-06-15 18:33:15]

On Mon, Jun 10, 2013 at 8:28 AM, Jói Sigurðsson <joi@chromium.org> wrote:
> Actually, Cait:  We need to make sure this gets done before the next
> branch point.  Could you open a tracking bug?
>
Joi, I have filed one here, crbug.com/250213. Let me know if it's good.

--
Thiago