dart:io | Add FileSystemEntity.stat() and FileStat class.

runtime/bin/dartutils.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_DARTUTILS_H_
 #define BIN_DARTUTILS_H_
 
 #include "include/dart_api.h"
 
 #include "platform/assert.h"
@@ skipping 189 matching lines @@
   static const char* GetCanonicalPath(const char* reference_dir,
                                       const char* filename);
 
   DISALLOW_ALLOCATION();
   DISALLOW_IMPLICIT_CONSTRUCTORS(DartUtils);
 };
 
 
 class CObject {
  public:
+  // These match the constants in sdk/lib/io/common.dart.

[Søren Gjesse, 2013/05/14 13:50:36]

These constants should be moved. They are not part of the serialization, but the
RPC protocol currently used between Dart code and the native threads.

[Bill Hesse, 2013/05/14 16:33:58]

I would do this, but I don't know where you think they should be moved to.  The
relevant file would seem to be native_service.h, but there is not much there
about this.
The code that uses these constants is in the implementation of the CObject class
in dartutils.cc, so the RPC protocol currently used between Dart and native
ports seems to be pretty well encapsulated in CObject and related classes, which
is in dartutils.

So I don't know where you want to move this, so I can't do it.


I could move them further down in the class, to where FileClosedError is
declared, but consts and enums are supposed to be at the top of the class.

On 2013/05/14 13:50:36, Søren Gjesse wrote:

[Søren Gjesse, 2013/05/15 14:06:35]

Let's create a new class NativePortRPC with these constants. and move then
methods IllegalArgumentError, FileClosedError and NewOSError (x2) from CObject
as well. It can be here in dartutils.h.

+  static const int kSuccess = 0;
+  static const int kArgumentError = 1;
+  static const int kOSError = 2;
+  static const int kFileClosedError = 3;
+
   explicit CObject(Dart_CObject *cobject) : cobject_(cobject) {}
   Dart_CObject::Type type() { return cobject_->type; }
   Dart_CObject::TypedDataType byte_array_type() {
     ASSERT(type() == Dart_CObject::kTypedData ||
            type() == Dart_CObject::kExternalTypedData);
     return cobject_->value.as_typed_data.type;
   }
 
   bool IsNull() { return type() == Dart_CObject::kNull; }
   bool IsBool() { return type() == Dart_CObject::kBool; }
@@ skipping 26 matching lines @@
   static CObject* Null();
   static CObject* True();
   static CObject* False();
   static CObject* Bool(bool value);
   static Dart_CObject* NewInt32(int32_t value);
   static Dart_CObject* NewInt64(int64_t value);
   static Dart_CObject* NewIntptr(intptr_t value);
   // TODO(sgjesse): Add support for kBigint.
   static Dart_CObject* NewDouble(double value);
   static Dart_CObject* NewString(int length);
   static Dart_CObject* NewString(const char* str);

[Søren Gjesse, 2013/05/14 13:50:36]

I don't think this comment belongs here. It is specific to the current RPC
protocol used between the Dart code and the native port.

[Bill Hesse, 2013/05/14 16:33:58]

Removed.  But the RPC protocol is exactly the function NewOSError,
FileClosedError, and IllegalArgumentError, just below, isn't it?

[Søren Gjesse, 2013/05/15 14:06:35]

That's right, see comment above.

+  // A CObject array cannot be returned as the result, since errors are
+  // encoded as arrays starting with a nonzero first element.  It must be
+  // wrapped in an array starting with kSuccess, and unwrapped by the receiver.
   static Dart_CObject* NewArray(int length);
   static Dart_CObject* NewUint8Array(int length);
   static Dart_CObject* NewExternalUint8Array(
       int64_t length, uint8_t* data, void* peer,
       Dart_WeakPersistentHandleFinalizer callback);
   static Dart_CObject* NewIOBuffer(int64_t length);
   static void FreeIOBufferData(Dart_CObject* object);
 
   Dart_CObject* AsApiCObject() { return cobject_; }
 
@@ skipping 228 matching lines @@
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CObjectExternalUint8Array);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // BIN_DARTUTILS_H_