Rename MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03

base/move.h

Index: base/move.h
diff --git a/base/move.h b/base/move.h
index 6743eb71667c7651ccb7c9571f3a0dce13732d41..51f112b3c10a54364c3c9798f4f0622c0d14b127 100644
--- a/base/move.h
+++ b/base/move.h
@@ -30,7 +30,7 @@
 //
 //  template <typename T>
 //  class scoped_ptr {
-//    MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03(type);
+//    DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(type);
 //   public:
 //    scoped_ptr(scoped_ptr&& other) : ptr_(other.release()) { }
 //    scoped_ptr& operator=(scoped_ptr&& other) {
@@ -50,9 +50,9 @@
 // for more details.
 
 #define MOVE_ONLY_TYPE_FOR_CPP_03(type) \
-  MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03(type)
+  DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(type)
 
-#define MOVE_ONLY_TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03(type)   \
+#define DISALLOW_COPY_AND_ASSIGN_WITH_MOVE_FOR_BIND(type)       \

[Nico, 2015/12/04 21:58:05]

What do you think is the long term plan for this? Once Pass() is gone, this will
go away completely I guess?

Maybe this could be

#define MOVE_ONLY(x) DISALLOW_COPY_AND_ASSIGN(x)

but I guess an explicit move ctor already implicitly deletes the default copy
ctor.

[danakj, 2015/12/04 22:01:47]

We'll still need the typedef whitelist once Pass() is gone, until some form of
Bind/Callback works.
Yah it does, and this macro doesn't actually make it movable.

Long long term this macro goes away and we always use DISALLOW_COPY_AND_ASSIGN,
I think.

I could make this macro actually use DISALLOW_COPY_AND_ASSIGN instead of
re-implementing it, would that be nice do you think?

I should maybe update/slim down the comment above to say use
DISALLOW_COPY_AND_ASSIGN if you don't need Callback support.

[dcheng, 2015/12/04 22:14:00]

I've been thinking: is there a value to forcing the use of MOVE_ONLY for
Callback compatibility? It's a pretty minor speedbump, since it's trivial to
just use this macro.

  private:                                                       \
   type(const type&) = delete;                                   \
   void operator=(const type&) = delete;                         \