Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1501763004: Revert of Clean up promises and fix an edge case bug (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Clean up promises and fix an edge case bug (patchset #4 id:60001 of https://codereview.chromium.org/1488783002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3266 Please request rebase upstream first. Original issue's description: > Clean up promises and fix an edge case bug > > This patch builds on previous Promise spec compliance work by > cleaning out some old code which existed to support > Promise.prototype.chain, rephrasing some code to correspond more > closely to the specification, and removing some incorrect brand > checking. A test is added for a bug in an edge case which was fixed. > > R=rossberg > BUG=v8:3641 > LOG=Y > > Committed: https://crrev.com/1deb89c8fd3cb69714ae0a24e3b5a4e78f6b73b4 > Cr-Commit-Position: refs/heads/master@{#32627} TBR=rossberg@chromium.org,caitpotter88@gmail.com,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3641 Committed: https://crrev.com/0f2ed07f45f4aa264dcfb48eeb9c781aaddfef1a Cr-Commit-Position: refs/heads/master@{#32629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -137 lines) Patch
M src/js/promise.js View 7 chunks +92 lines, -44 lines 0 comments Download
M test/mjsunit/es6/promises.js View 15 chunks +36 lines, -31 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download
D test/mjsunit/regress/regress-3641.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Clean up promises and fix an edge case bug
5 years ago (2015-12-05 08:50:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501763004/1
5 years ago (2015-12-05 08:51:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-05 08:51:13 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-05 08:51:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f2ed07f45f4aa264dcfb48eeb9c781aaddfef1a
Cr-Commit-Position: refs/heads/master@{#32629}

Powered by Google App Engine
This is Rietveld 408576698