Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1501763002: Revert "PPC: Provide call counts for constructor calls, surface them as a vector IC." (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "PPC: Provide call counts for constructor calls, surface them as a vector IC." This reverts commit 55b41ff32ded37bb4730a6e13ff831c5def2841e. Port e89e08ca144693f522ddc46ffaf00d987515cc20 Reason for revert: Seems to be (mostly) responsible for the most recent Speedometer regression, not 100% sure. Let's see what the bots have to say. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/cc17ead4444299f764b84ef86ff23b92e8e2e778 Cr-Commit-Position: refs/heads/master@{#32624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +4 lines, -21 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
5 years ago (2015-12-04 16:36:15 UTC) #1
michael_dawson
On 2015/12/04 16:36:15, mtbrandyberry wrote: lgtm
5 years ago (2015-12-04 17:24:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501763002/1
5 years ago (2015-12-04 17:28:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 17:29:07 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-04 17:29:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc17ead4444299f764b84ef86ff23b92e8e2e778
Cr-Commit-Position: refs/heads/master@{#32624}

Powered by Google App Engine
This is Rietveld 408576698