content/browser/renderer_host/render_process_host_impl.cc - Issue 15017018: Prevent unauthorized commits of the Chrome Web Store URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 15017018: Prevent unauthorized commits of the Chrome Web Store URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 2e7bba8213b63d973faae74ba03d1c3731754d5a..09ef9bac973a6942728953c27d503356be909bde 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -721,7 +721,8 @@ void RenderProcessHostImpl::ReceivedBadMessage() {

// crash.

CHECK(false);

}

- NOTREACHED();

+ // We kill the renderer but don't include a NOTREACHED, because we want the

+ // browser to try to survive when it gets illegal messages from the renderer.

base::KillProcess(GetHandle(), RESULT_CODE_KILLED_BAD_MESSAGE,

false);

}