Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 15017018: Prevent unauthorized commits of the Chrome Web Store URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove NOTREACHED. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 2e7bba8213b63d973faae74ba03d1c3731754d5a..3a4e4ea6377ea13cedbc306396c6d24c8c744f07 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -721,7 +721,8 @@ void RenderProcessHostImpl::ReceivedBadMessage() {
// crash.
CHECK(false);
}
- NOTREACHED();
+ // We kill the renderer but don't include a NOTREACHED, because it is possible
nasko 2013/05/13 18:14:27 nit: "it is possible" doesn't seem as strong messa
Charlie Reis 2013/05/13 20:10:51 We can't always survive: renderers can kill the br
+ // for the browser to survive when it gets illegal messages from the renderer.
base::KillProcess(GetHandle(), RESULT_CODE_KILLED_BAD_MESSAGE,
false);
}

Powered by Google App Engine
This is Rietveld 408576698