Issue 15017017: [NaCl SDK] Before bundling, clean all built libraries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15017017: [NaCl SDK] Before bundling, clean all built libraries. (Closed)

Created:
7 years, 7 months ago by binji

Modified:
7 years, 7 months ago

Reviewers:
noelallen1, Sam Clegg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[NaCl SDK] Before bundling, clean all built libraries. The "clean" make rule wasn't cleaning for all toolchains. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200115

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -52 lines)			Patch
M	native_client_sdk/src/build_tools/build_projects.py	View	1 2 3	3 chunks	+3 lines, -4 lines	0 comments	Download
M	native_client_sdk/src/build_tools/build_sdk.py	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/examples/Makefile	View	1 2 3	2 chunks	+17 lines, -17 lines	0 comments	Download
M	native_client_sdk/src/tools/common.mk	View	1 2 3	4 chunks	+44 lines, -29 lines	0 comments	Download

Total messages: 7 (0 generated)

binji

PTAL, changed it so we use targets per project/toolchain instead of explicit list in recipe ...

7 years, 7 months ago (2013-05-14 20:34:54 UTC) #4

Sam Clegg

On 2013/05/14 21:19:14, Sam Clegg wrote: > lgtm That linux bot failure should be fixed ...

7 years, 7 months ago (2013-05-14 23:26:04 UTC) #6

binji

7 years, 7 months ago (2013-05-15 00:08:33 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 manually as r200115 (presubmit successful).