Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/WebKit/chromium/src/WebFrameImpl.h

Issue 15017002: WebFrame::selectRange and moveCaret should behave like mouse selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebFrameImpl.h
diff --git a/Source/WebKit/chromium/src/WebFrameImpl.h b/Source/WebKit/chromium/src/WebFrameImpl.h
index 1671bfdb08aa76e448e4be12fdc6f315fca476b6..1b524085c3818d1fca012b05a6801cfec542d6a1 100644
--- a/Source/WebKit/chromium/src/WebFrameImpl.h
+++ b/Source/WebKit/chromium/src/WebFrameImpl.h
@@ -51,6 +51,7 @@ class IntSize;
class KURL;
class Node;
class Range;
+class RenderObject;
class SubstituteData;
struct FrameLoadRequest;
struct WindowFeatures;
@@ -188,6 +189,8 @@ public:
virtual void selectRange(const WebPoint& base, const WebPoint& extent);
virtual void selectRange(const WebRange&);
virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&);
+ virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent);
+ virtual void moveCaretSelection(const WebPoint&);
virtual int printBegin(const WebPrintParams&,
const WebNode& constrainToNode,
bool* useBrowserOverlays);
@@ -401,8 +404,8 @@ private:
void loadJavaScriptURL(const WebCore::KURL&);
- // Returns a hit-tested VisiblePosition for the given point
- WebCore::VisiblePosition visiblePositionForWindowPoint(const WebPoint&);
+ // Returns the VisiblePosition for the given point in the render object.
+ WebCore::VisiblePosition visiblePositionForWindowPoint(const WebPoint&, WebCore::RenderObject*);
FrameLoaderClientImpl m_frameLoaderClient;

Powered by Google App Engine
This is Rietveld 408576698