WebFrame::selectRange and moveCaret should behave like mouse selection

Source/WebKit/chromium/src/WebFrameImpl.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
 #include <wtf/text/WTFString.h>
 
 namespace WebCore {
 class GraphicsContext;
 class HTMLInputElement;
 class HistoryItem;
 class IntSize;
 class KURL;
 class Node;
 class Range;
+class RenderObject;
 class SubstituteData;
 struct FrameLoadRequest;
 struct WindowFeatures;
 }
 
 namespace WebKit {
 class ChromePrintContext;
 class WebDataSourceImpl;
 class WebInputElement;
 class WebFrameClient;
@@ skipping 117 matching lines @@
     virtual void replaceMisspelledRange(const WebString&);
     virtual void removeSpellingMarkers();
     virtual bool hasSelection() const;
     virtual WebRange selectionRange() const;
     virtual WebString selectionAsText() const;
     virtual WebString selectionAsMarkup() const;
     virtual bool selectWordAroundCaret();
     virtual void selectRange(const WebPoint& base, const WebPoint& extent);
     virtual void selectRange(const WebRange&);
     virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&);
+    virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent);
+    virtual void moveCaretSelection(const WebPoint&);
     virtual int printBegin(const WebPrintParams&,
                            const WebNode& constrainToNode,
                            bool* useBrowserOverlays);
     virtual float printPage(int pageToPrint, WebCanvas*);
     virtual float getPrintPageShrink(int page);
     virtual void printEnd();
     virtual bool isPrintScalingDisabledForPlugin(const WebNode&);
     virtual bool hasCustomPageSizeStyle(int pageIndex);
     virtual bool isPageBoxVisible(int pageIndex);
     virtual void pageSizeAndMarginsInPixels(int pageIndex,
@@ skipping 193 matching lines @@
     // Called by a DeferredScopeStringMatches instance.
     void callScopeStringMatches(
         DeferredScopeStringMatches*, int identifier, const WebString& searchText,
         const WebFindOptions&, bool reset);
 
     // Determines whether to invalidate the content area and scrollbar.
     void invalidateIfNecessary();
 
     void loadJavaScriptURL(const WebCore::KURL&);
 
-    // Returns a hit-tested VisiblePosition for the given point
-    WebCore::VisiblePosition visiblePositionForWindowPoint(const WebPoint&);
+    // Returns the VisiblePosition for the given point in the render object.
+    WebCore::VisiblePosition visiblePositionForWindowPoint(const WebPoint&, WebCore::RenderObject*);
 
     FrameLoaderClientImpl m_frameLoaderClient;
 
     WebFrameClient* m_client;
 
     // A way for the main frame to keep track of which frame has an active
     // match. Should be 0 for all other frames.
     WebFrameImpl* m_currentActiveMatchFrame;
 
     // The range of the active match for the current frame.
@@ skipping 73 matching lines @@
     long long m_identifier;
 
     // Ensure we don't overwrite valid history data during same document loads
     // from HistoryItems
     bool m_inSameDocumentHistoryLoad;
 };
 
 } // namespace WebKit
 
 #endif