Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1501673002: Revert of [es6] Correctify and unify ArrayBuffer and SharedArrayBuffer constructors. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Correctify and unify ArrayBuffer and SharedArrayBuffer constructors. (patchset #2 id:20001 of https://codereview.chromium.org/1500543002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/1497763004/ Original issue's description: > [es6] Correctify and unify ArrayBuffer and SharedArrayBuffer constructors. > > The ArrayBuffer and SharedArrayBuffer constructors should raise an > exception when called with no arguments or undefined length. Also > unified the ArrayBuffer and SharedArrayBuffer implementations as C++ > builtins, and removed some (now) obsolete runtime entries. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3235ccbb7826ceec2188f6ebab98fc851b54f60e > Cr-Commit-Position: refs/heads/master@{#32590} TBR=yangguo@chromium.org,cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/154a493cb771553ffb71b38e957491178950a7ac Cr-Commit-Position: refs/heads/master@{#32606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -163 lines) Patch
M src/bootstrapper.cc View 4 chunks +12 lines, -39 lines 0 comments Download
M src/builtins.h View 1 chunk +40 lines, -44 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M src/js/arraybuffer.js View 2 chunks +33 lines, -0 lines 0 comments Download
M src/js/harmony-sharedarraybuffer.js View 2 chunks +33 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/regress-446156.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/typedarray.js View 4 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/reflect-get-prototype-of.js View 2 chunks +2 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/sharedarraybuffer.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-522496.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [es6] Correctify and unify ArrayBuffer and SharedArrayBuffer constructors.
5 years ago (2015-12-04 10:37:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501673002/1
5 years ago (2015-12-04 10:37:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 10:38:29 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 10:38:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/154a493cb771553ffb71b38e957491178950a7ac
Cr-Commit-Position: refs/heads/master@{#32606}

Powered by Google App Engine
This is Rietveld 408576698