Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 150163003: drive: Switch Drive mount path to per-profile one. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
hashimoto, hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yoshiki
Visibility:
Public.

Description

drive: Switch Drive mount path to per-profile one. This is for fully supporting multi-profile in Files.app. Drive folder from different profiles need to have different paths. The change includes: - Change mount path from /special/drive to /special/drive-<user-id-hash>. Stored settings (like Download path) are migrated by MigratePathFromOldFormat. - Profile extraction function from the above path format that will be used in next patch. (I included the function in the current patch to emphasize that the new path format is intended for this type of use.) - Change mount point name from drive to drive-<user-id-hash> - Mount point is added to the system global instance, not the per-profile ones (otherwise cross-profile copy is impossible.) BUG=336123 R=hashimoto@chromium.org, hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248848

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -18 lines) Patch
M chrome/browser/chromeos/drive/drive_integration_service.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.h View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 4 chunks +26 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 3 chunks +48 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/path_util_unittest.cc View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
kinaba
+hirono, +hashimoto: ptal. CC +yoshiki: I hope we are ready for the URL/path change in ...
6 years, 10 months ago (2014-02-04 00:13:13 UTC) #1
hashimoto
lgtm
6 years, 10 months ago (2014-02-04 02:32:04 UTC) #2
hirono
lgtm with nit! https://codereview.chromium.org/150163003/diff/110015/chrome/browser/chromeos/drive/file_system_util.cc File chrome/browser/chromeos/drive/file_system_util.cc (right): https://codereview.chromium.org/150163003/diff/110015/chrome/browser/chromeos/drive/file_system_util.cc#newcode232 chrome/browser/chromeos/drive/file_system_util.cc:232: base::FilePath base = GetDriveMountPointPath(original_profile); nit: const
6 years, 10 months ago (2014-02-04 03:19:24 UTC) #3
kinaba
https://codereview.chromium.org/150163003/diff/110015/chrome/browser/chromeos/drive/file_system_util.cc File chrome/browser/chromeos/drive/file_system_util.cc (right): https://codereview.chromium.org/150163003/diff/110015/chrome/browser/chromeos/drive/file_system_util.cc#newcode232 chrome/browser/chromeos/drive/file_system_util.cc:232: base::FilePath base = GetDriveMountPointPath(original_profile); On 2014/02/04 03:19:24, hirono wrote: ...
6 years, 10 months ago (2014-02-04 04:18:44 UTC) #4
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-04 04:18:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/150163003/390001
6 years, 10 months ago (2014-02-04 04:19:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 05:35:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222782
6 years, 10 months ago (2014-02-04 05:35:24 UTC) #8
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-04 06:44:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/150163003/390001
6 years, 10 months ago (2014-02-04 06:44:28 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 07:50:15 UTC) #11
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120552
6 years, 10 months ago (2014-02-04 07:50:15 UTC) #12
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-04 09:01:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/150163003/390001
6 years, 10 months ago (2014-02-04 09:02:46 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 10:05:16 UTC) #15
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120642
6 years, 10 months ago (2014-02-04 10:05:17 UTC) #16
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-05 00:04:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/150163003/390001
6 years, 10 months ago (2014-02-05 00:10:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/150163003/390001
6 years, 10 months ago (2014-02-05 01:43:38 UTC) #19
kinaba
6 years, 10 months ago (2014-02-05 04:27:44 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 manually as r248848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698