Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 15016009: Rename runtime enabled check for prefixed Encrypted Media API. (Closed)

Created:
7 years, 7 months ago by ddorwin
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium, feature-media-reviews_chromium.org, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename runtime enabled check for prefixed Encrypted Media API. This will allow the prefixed and unprefixed versions to be controlled independently. The new unprefixed runtime check is also added. encryptedMediaAnyVersion enables MediaKeyError when either version is enabled and is managed by the other controls. BUG=224791 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150618

Patch Set 1 #

Total comments: 1

Patch Set 2 : 'WebKit' > 'Legacy' #

Patch Set 3 : fix ordering #

Patch Set 4 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
M Source/WebKit/chromium/public/WebRuntimeFeatures.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +24 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 1 chunk +11 lines, -10 lines 0 comments Download
M Source/core/html/MediaKeyError.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/MediaKeyEvent.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 2 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ddorwin
This is similar to the runtime check changes in https://codereview.chromium.org/14619016/. This CL also adds the ...
7 years, 7 months ago (2013-05-16 23:28:54 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/15016009/diff/1/Source/WebKit/chromium/public/WebRuntimeFeatures.h File Source/WebKit/chromium/public/WebRuntimeFeatures.h (right): https://codereview.chromium.org/15016009/diff/1/Source/WebKit/chromium/public/WebRuntimeFeatures.h#newcode89 Source/WebKit/chromium/public/WebRuntimeFeatures.h:89: WEBKIT_EXPORT static bool isWebKitEncryptedMediaEnabled(); enableDeprecatedEncryptedMedia ? We're trying ...
7 years, 7 months ago (2013-05-17 05:27:14 UTC) #2
ddorwin
Replaced "WebKit" with "Legacy". "WebKit" made sense in the MSE case because there is an ...
7 years, 7 months ago (2013-05-18 00:31:12 UTC) #3
abarth-chromium
ok
7 years, 7 months ago (2013-05-18 00:44:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ddorwin@chromium.org/15016009/13001
7 years, 7 months ago (2013-05-18 00:53:13 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-18 01:43:20 UTC) #6
Message was sent while issue was closed.
Change committed as 150618

Powered by Google App Engine
This is Rietveld 408576698